Issue 4756047: code review 4756047: http: drain the pipe output in TestHandlerPanic to avoi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4756047: code review 4756047: http: drain the pipe output in TestHandlerPanic to avoi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by dsymonds

Modified:
13 years, 9 months ago

Reviewers:
brainman

CC:
r, golang-dev

Visibility:
Public.

Description

http: drain the pipe output in TestHandlerPanic to avoid logging deadlock.

Patch Set 2 : diff -r d950e9bd6223 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d950e9bd6223 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r d950e9bd6223 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6c4bbedb13df https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/http/serve_test.go	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-07-18 02:51:47 UTC) #1

http://codereview.appspot.com/4756047/diff/5001/src/pkg/http/serve_test.go File src/pkg/http/serve_test.go (right): http://codereview.appspot.com/4756047/diff/5001/src/pkg/http/serve_test.go#newcode825 src/pkg/http/serve_test.go:825: go io.Copy(ioutil.Discard, pr) why not just close it?

13 years, 9 months ago (2011-07-18 02:53:09 UTC) #2

dsymonds

*** Submitted as http://code.google.com/p/go/source/detail?r=3be72c2cebab *** http: drain the pipe output in TestHandlerPanic to avoid logging ...

13 years, 9 months ago (2011-07-18 02:59:25 UTC) #5

brainman

13 years, 9 months ago (2011-07-18 03:06:21 UTC) #6

LGTM. Thank you.

Very easy to shoot yourself in the foot <g>.

Expand All Messages | Collapse All Messages