Issue 4755046: code review 4755046: cmd/5l/Makefile: directory prefix nit, "../5l/" is not ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4755046: code review 4755046: cmd/5l/Makefile: directory prefix nit, "../5l/" is not ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by lucio

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, r, rsc

Visibility:
Public.

Description

cmd/5l/Makefile: directory prefix nit, "../5l/" is not needed.

Patch Set 1 #

Patch Set 2 : diff -r 97bc301fb8f4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 97bc301fb8f4 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/5l/Makefile	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

lucio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-07-17 13:31:48 UTC) #1

LGTM but it's still inconsistent the a's, c's, and g's do this, only the l's ...

13 years, 9 months ago (2011-07-17 22:46:01 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=360a3e7b308e *** cmd/5l/Makefile: directory prefix nit, "../5l/" is not needed. R=golang-dev, r ...

13 years, 9 months ago (2011-07-17 22:46:53 UTC) #3

lucio

13 years, 9 months ago (2011-07-18 04:23:43 UTC) #4

One could have an "arch" directory, but that would be overkill right now.
I'm not sure where first the prefix fell out, I would not like to put it
back.  I could, at a squeeze.

Lucio.

On Mon, Jul 18, 2011 at 12:46 AM, <r@golang.org> wrote:

> LGTM
>
> but it's still inconsistent
>
> the a's, c's, and g's do this, only the l's don't.
>
>
>
http://codereview.appspot.com/**4755046/<http://codereview.appspot.com/4755046/>
>

Expand All Messages | Collapse All Messages