Issue 4755041: code review 4755041: runtime: add native xadd() implementation for 386/amd64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4755041: code review 4755041: runtime: add native xadd() implementation for 386/amd64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by dvyukov

Modified:
14 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: add native xadd() implementation for 386/amd64 benchmark old ns/op new ns/op delta BenchmarkSemaUncontended 37.40 34.10 -8.82% BenchmarkSemaUncontended-2 18.90 17.70 -6.35% BenchmarkSemaUncontended-4 11.90 10.90 -8.40% BenchmarkSemaUncontended-8 6.26 5.19 -17.09% BenchmarkSemaUncontended-16 4.39 3.91 -10.93% BenchmarkSemaSyntNonblock 38.00 35.30 -7.11% BenchmarkSemaSyntNonblock-2 83.00 46.70 -43.73% BenchmarkSemaSyntNonblock-4 124.00 101.00 -18.55% BenchmarkSemaSyntNonblock-8 124.00 116.00 -6.45% BenchmarkSemaSyntNonblock-16 148.00 114.00 -22.97% (on HP Z600 2 x Xeon E5620, 8 HT cores, 2.40GHz)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -14 lines)			Patch
M	src/pkg/runtime/386/asm.s	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/amd64/asm.s	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/arm/atomic.c	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.c	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-07-15 12:40:52 UTC) #1

rsc

14 years, 2 months ago (2011-07-15 15:27:22 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=aa5c2d235e21 ***

runtime: native xadd for 386/amd64

benchmark                          old ns/op    new ns/op    delta
BenchmarkSemaUncontended               37.40        34.10   -8.82%
BenchmarkSemaUncontended-2             18.90        17.70   -6.35%
BenchmarkSemaUncontended-4             11.90        10.90   -8.40%
BenchmarkSemaUncontended-8              6.26         5.19  -17.09%
BenchmarkSemaUncontended-16             4.39         3.91  -10.93%
BenchmarkSemaSyntNonblock              38.00        35.30   -7.11%
BenchmarkSemaSyntNonblock-2            83.00        46.70  -43.73%
BenchmarkSemaSyntNonblock-4           124.00       101.00  -18.55%
BenchmarkSemaSyntNonblock-8           124.00       116.00   -6.45%
BenchmarkSemaSyntNonblock-16          148.00       114.00  -22.97%

(on HP Z600 2 x Xeon E5620, 8 HT cores, 2.40GHz)

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4755041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages