code review 4749042: cmd/ld: Enhancement for porting to Plan 9 legacy.

cmd/ld: Enhancement for porting to Plan 9 legacy.

ld/data.c:
. Format specifier with corresponding cast to cater for all
  architectures (llux and vlong).

ld/ldelf.c:
ld/ldmacho.c:
. Missing "pn" argument in diag() calls.

ld/ldpe.c:
. Dropped "sym->sectnum" in diag() call.
. Typo in a comment.

ld/lib.h:
. Added varargck pragma for "O".

[lucio, 2011-07-15 09:23:08]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
rsc@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-07-15 15:49:13]

nice.
in data.c the usual spellings are llux and uvlong.

[lucio, 2011-07-15 18:52:29]

I was wondering about the spelling.  I'll fix it.

I forgot to mentioned that I can only test these fixes for UBUNTU/386,
please make sure it all works.

And, yes, I was also rather pleased with myself for coming up with
such a trivial work-around :-)

Lucio.

On 7/15/11, Russ Cox <rsc@golang.org> wrote:
> nice.
> in data.c the usual spellings are llux and uvlong.
>

[lucio, 2011-07-15 19:07:44]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
rsc@golang.org),

Please take another look.

[rsc, 2011-07-19 14:47:21]

LGTM

[rsc, 2011-07-19 14:47:52]

please hg sync; hg mail 4749042

[lucio, 2011-07-23 20:09:23]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[lucio, 2011-07-24 16:08:37]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-07-25 17:45:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=0da598877ce7 ***

ld: fix build on Plan 9

ld/data.c:
. Format specifier with corresponding cast to cater for all
  architectures (llux and vlong).

ld/ldelf.c:
ld/ldmacho.c:
. Missing "pn" argument in diag() calls.

ld/ldpe.c:
. Dropped "sym->sectnum" in diag() call.
. Typo in a comment.

ld/lib.h:
. Added varargck pragma for "O".

R=rsc
CC=golang-dev
http://codereview.appspot.com/4749042

Committer: Russ Cox <rsc@golang.org>