Issue 4747044: code review 4747044: cmd/6a, cmd/6c, cmd/6l: Adjustment for compilation unde...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4747044: code review 4747044: cmd/6a, cmd/6c, cmd/6l: Adjustment for compilation unde... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by lucio

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/6a, cmd/6c, cmd/6l: Adjustment for compilation under Plan 9 legacy. 6a/a.h: . Dropped <u.h> and <libc.h>. . Made definition of EOF conditional. 6a/a.y: . Added <u.h> and <libc.h>. 6a/lex.c: . Added <u.h> and <libc.h>. . Dropped <ctype.h> (now in <u.h>). 6c/gc.h: . Added varargck pragma for "lD". 6c/swt.c: . Dropped unused "thestring" argument in Bprint() calls. 6l/Makefile: . Dropped unneeded directory prefix. 6l/l.h: . Dropped unneeded directory prefix. . Added varargck pragma for "I" and "i". 6l/obj.c: . Dropped unneeded assignment. . Dropped unreachable goto statement. 6l/pass.c: . Dropped assignments flagged as unused. 6l/prof.c: . Replaced "#if 0" with "#ifdef NOTDEF". 6l/span.c: . Dropped unused incrementation. . Added USED() as required. . Dropped unreachable "return" statement.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -17 lines)			Patch
M	src/cmd/6a/a.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/6a/a.y	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/6a/lex.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/6c/gc.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/6c/swt.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/6l/Makefile	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/6l/l.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/6l/obj.c	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/cmd/6l/pass.c	View	1	4 chunks	+0 lines, -5 lines	0 comments	Download
M	src/cmd/6l/prof.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/6l/span.c	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lucio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-07-15 09:59:01 UTC) #1

rsc

13 years, 9 months ago (2011-07-15 15:58:45 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d7b793a7d35d ***

6a, 6c, 6l: fix for Plan 9 build

6a/a.h:
. Dropped <u.h> and <libc.h>.
. Made definition of EOF conditional.

6a/a.y:
. Added <u.h> and <libc.h>.

6a/lex.c:
. Added <u.h> and <libc.h>.
. Dropped <ctype.h> (now in <u.h>).

6c/gc.h:
. Added varargck pragma for "lD".

6c/swt.c:
. Dropped unused "thestring" argument in Bprint() calls.

6l/Makefile:
. Dropped unneeded directory prefix.

6l/l.h:
. Dropped unneeded directory prefix.
. Added varargck pragma for "I" and "i".

6l/obj.c:
. Dropped unneeded assignment.
. Dropped unreachable goto statement.

6l/pass.c:
. Dropped assignments flagged as unused.

6l/prof.c:
. Replaced "#if 0" with "#ifdef NOTDEF".

6l/span.c:
. Dropped unused incrementation.
. Added USED() as required.
. Dropped unreachable "return" statement.

R=golang-dev
CC=golang-dev, rsc
http://codereview.appspot.com/4747044

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages