code review 4746047: go/build: fixes for windows paths

go/build: fixes for windows paths

[brainman, 2011-07-19 00:46:43]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[mattn, 2011-07-19 00:52:46]

LGTM

On 2011/07/19 00:46:43, brainman wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

[brainman, 2011-07-19 00:58:16]

I have unresolved issue here.

I think isLocalPath() should work for paths like c:.\aa and c:..\aa and c:aa.
They are similar to (./foo ../foo . ..):

c:.\aa  - directory aa in the current directory of drive c:
c:..\aa - directory aa in the parent of current directory of drive c:
c:aa    - same as c:.\aa

None of these are filepath.IsAbs, but should be accepted as "local path".

Needs some pointers on how to implement these. Thank you.

Alex

[adg, 2011-07-19 01:01:35]

On 2011/07/19 00:58:16, brainman wrote:
> I have unresolved issue here.
> 
> I think isLocalPath() should work for paths like c:.\aa and c:..\aa and c:aa.
> They are similar to (./foo ../foo . ..):
> 
> c:.\aa  - directory aa in the current directory of drive c:
> c:..\aa - directory aa in the parent of current directory of drive c:
> c:aa    - same as c:.\aa

I'm happy for you to use the same check as windows' filepath.volumeName to see
if the path begins with a drive letter.

Andrew

[brainman, 2011-07-19 02:33:53]

Hello golang-dev@googlegroups.com, mattn.jp@gmail.com, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-07-19 03:40:46]

LGTM

http://codereview.appspot.com/4746047/diff/12001/src/pkg/path/filepath/path_w...
File src/pkg/path/filepath/path_windows.go (right):

http://codereview.appspot.com/4746047/diff/12001/src/pkg/path/filepath/path_w...
src/pkg/path/filepath/path_windows.go:23: // If given "C:\foo\bar", return "C:"
on windows.
Given "C:\foo\bar" it returns "C:" under windows.
On other platforms it returns "".

[brainman, 2011-07-19 04:02:40]

*** Submitted as http://code.google.com/p/go/source/detail?r=16c14fb2fea5 ***

go/build: fixes for windows paths

R=golang-dev, mattn.jp, adg
CC=golang-dev
http://codereview.appspot.com/4746047

http://codereview.appspot.com/4746047/diff/12001/src/pkg/path/filepath/path_w...
File src/pkg/path/filepath/path_windows.go (right):

http://codereview.appspot.com/4746047/diff/12001/src/pkg/path/filepath/path_w...
src/pkg/path/filepath/path_windows.go:23: // If given "C:\foo\bar", return "C:"
on windows.
On 2011/07/19 03:40:46, adg wrote:
> Given "C:\foo\bar" it returns "C:" under windows.
> On other platforms it returns "".

Done.