code review 4743041: go/build: less aggressive failure when GOROOT not found

go/build: less aggressive failure when GOROOT not found

[adg, 2011-07-15 03:28:12]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-07-15 03:31:33]

why?  if $GOROOT doesn't exist you cannot link anything.

[adg, 2011-07-15 03:32:40]

On 15 July 2011 13:31, Russ Cox <rsc@golang.org> wrote:
> why?  if $GOROOT doesn't exist you cannot link anything.

Users of go/build don't necessarily care about Path.

In this instance, Robert is using go/build in godoc and it's failing
on appengine because GOROOT can't be found.

Andrew

[rsc, 2011-07-15 03:35:08]

LGTM

On Thu, Jul 14, 2011 at 23:32, Andrew Gerrand <adg@golang.org> wrote:
> On 15 July 2011 13:31, Russ Cox <rsc@golang.org> wrote:
>> why?  if $GOROOT doesn't exist you cannot link anything.
>
> Users of go/build don't necessarily care about Path.
>
> In this instance, Robert is using go/build in godoc and it's failing
> on appengine because GOROOT can't be found.

Oh!  It's the package not the tool.

[dsymonds, 2011-07-15 03:39:01]

LGTM

http://codereview.appspot.com/4743041/diff/1/src/pkg/go/build/path.go
File src/pkg/go/build/path.go (right):

http://codereview.appspot.com/4743041/diff/1/src/pkg/go/build/path.go#newcode16
src/pkg/go/build/path.go:16: // Path is a validated list of Trees derived from
$GOPATH at init.
perhaps add a comment saying what this will be if there's no GOROOT?

[adg, 2011-07-15 03:39:20]

Hello golang-dev@googlegroups.com, rsc@golang.org, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-07-15 03:45:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=c9f8fa398db4 ***

go/build: less aggressive failure when GOROOT not found

R=golang-dev, rsc, dsymonds
CC=golang-dev
http://codereview.appspot.com/4743041