Issue 4728042: [PATCH] Use the new APFloat::convertToInt(APSInt) function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4728042: [PATCH] Use the new APFloat::convertToInt(APSInt) function (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by Jeffrey Yasskin

Modified:
12 years, 9 months ago

Reviewers:
cfe-commits

Visibility:
Public.

Description

Use the new APFloat::convertToInt(APSInt) function to simplify uses of convertToInt(integerParts*) and make them more reliable. Relies on http://codereview.appspot.com/4738043.

Patch Set 1 #

Patch Set 2 : Add FIXME back; remove a redundant isSigned specification. #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
	M	lib/AST/ExprConstant.cpp	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
	M	lib/Sema/SemaChecking.cpp	View	1	1 chunk	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Jeffrey Yasskin

12 years, 9 months ago (2011-07-15 00:06:02 UTC) #1

Initial diff at http://codereview.appspot.com/download/issue4728042_1.diff.

Expand All Messages | Collapse All Messages