Issue 4724041: Several fixes for annotate-spacing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4724041: Several fixes for annotate-spacing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by joeneeman

Modified:
12 years, 8 months ago

Reviewers:
lemzwerg, Neil Puttock, Reinhold

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Several fixes for annotate-spacing. Fixes annotate-spacing to use the new spacing names. Annotates spacing between staves as well as spacing between systems. Fixes some collisions between annotations.

Patch Set 1 #

Total comments: 2

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -52 lines)			Patch
M	lily/include/system.hh	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lily/system.cc	View	1 chunk	+38 lines, -0 lines	0 comments	Download
M	scm/paper-system.scm	View	2 chunks	+55 lines, -23 lines	2 comments	Download
M	scm/stencil.scm	View	1 chunk	+29 lines, -29 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

lemzwerg

LGTM. This kind of patch is something I wouldn't discuss on Rietveld but rather push ...

12 years, 9 months ago (2011-07-14 11:40:46 UTC) #1

Neil Puttock

Hi Joe, Do you have a follow-up patch which defines ly:get-spacing-spec? Cheers, Neil

12 years, 9 months ago (2011-07-14 21:10:41 UTC) #2

Reinhold

http://codereview.appspot.com/4724041/diff/1/scm/paper-system.scm File scm/paper-system.scm (right): http://codereview.appspot.com/4724041/diff/1/scm/paper-system.scm#newcode112 scm/paper-system.scm:112: (ly:output-def-lookup layout 'system-system-spacing)))) What's the case with all the ...

12 years, 8 months ago (2011-09-05 21:10:37 UTC) #3

joeneeman

12 years, 8 months ago (2011-09-08 00:51:07 UTC) #4

http://codereview.appspot.com/4724041/diff/1/scm/paper-system.scm
File scm/paper-system.scm (right):

http://codereview.appspot.com/4724041/diff/1/scm/paper-system.scm#newcode112
scm/paper-system.scm:112: (ly:output-def-lookup layout
'system-system-spacing))))
On 2011/09/05 21:10:38, Reinhold wrote:
> What's the case with all the other *-*-spacing variables? In particular,
> -) top-markup-spacing
> -) top-system-spacing
> -) score-system-spacing

Thanks for the bump. I've made many changes since this issue  was created (and
rebased several times), so I'm closing this issue and making another one. FWIW,
the new patch takes care of score-system-spacing and top-*-spacing is handled
elsewhere (in annotate-top-space).

Expand All Messages | Collapse All Messages