Not quite sure what patch fixed this one and I'm too lazy to figure it ...
13 years, 8 months ago
(2011-07-12 12:55:36 UTC)
#1
Not quite sure what patch fixed this one and I'm too lazy to figure it out
now.
Committed to branch.
Diego.
* g++.dg/pph/c4pr36533.cc: Mark fixed.
diff --git a/gcc/testsuite/g++.dg/pph/c4pr36533.cc
b/gcc/testsuite/g++.dg/pph/c4pr36533.cc
index 0093db1..ce2bf1f 100644
--- a/gcc/testsuite/g++.dg/pph/c4pr36533.cc
+++ b/gcc/testsuite/g++.dg/pph/c4pr36533.cc
@@ -1,3 +1,2 @@
/* { dg-options "-w -fpermissive" } */
-// pph asm xdiff
#include "c4pr36533.h"
--
This patch is available for review at http://codereview.appspot.com/4708041
My patch at http://codereview.appspot.com/4657092/ was fixing this. Did you apply that already? I didn't see ...
13 years, 8 months ago
(2011-07-12 18:02:37 UTC)
#2
My patch at http://codereview.appspot.com/4657092/ was fixing this.
Did you apply that already? I didn't see it as part of your commits to date?
Gab
On Tue, Jul 12, 2011 at 5:55 AM, Diego Novillo <dnovillo@google.com> wrote:
>
> Not quite sure what patch fixed this one and I'm too lazy to figure it out
> now.
>
> Committed to branch.
>
>
> Diego.
>
> * g++.dg/pph/c4pr36533.cc: Mark fixed.
>
> diff --git a/gcc/testsuite/g++.dg/pph/c4pr36533.cc
b/gcc/testsuite/g++.dg/pph/c4pr36533.cc
> index 0093db1..ce2bf1f 100644
> --- a/gcc/testsuite/g++.dg/pph/c4pr36533.cc
> +++ b/gcc/testsuite/g++.dg/pph/c4pr36533.cc
> @@ -1,3 +1,2 @@
> /* { dg-options "-w -fpermissive" } */
> -// pph asm xdiff
> #include "c4pr36533.h"
>
> --
> This patch is available for review at http://codereview.appspot.com/4708041
On Tue, Jul 12, 2011 at 14:02, Gabriel Charette <gchare@google.com> wrote: > My patch at ...
13 years, 8 months ago
(2011-07-12 18:12:58 UTC)
#3
On Tue, Jul 12, 2011 at 14:02, Gabriel Charette <gchare@google.com> wrote:
> My patch at http://codereview.appspot.com/4657092/ was fixing this.
>
> Did you apply that already? I didn't see it as part of your commits to date?
Ah, so that was it. No, it wasn't 4657092. I think we both fixed
this independently. I now have a variant of 4657092 in my tree, but
it's still causing other grief. I should have it ready today.
Diego.
Issue 4708041: [pph] Mark c4pr36533.cc fixed
(Closed)
Created 13 years, 8 months ago by Diego Novillo
Modified 13 years, 7 months ago
Reviewers:
Base URL:
Comments: 0