Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3266)

Issue 4708041: [pph] Mark c4pr36533.cc fixed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by Diego Novillo
Modified:
12 years, 8 months ago
Reviewers:
CC:
Lawrence Crowl, Gabriel Charette, gcc-patches_gcc.gnu.org
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M gcc/testsuite/ChangeLog.pph View 1 chunk +4 lines, -0 lines 0 comments Download
M gcc/testsuite/g++.dg/pph/c4pr36533.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
Diego Novillo
Not quite sure what patch fixed this one and I'm too lazy to figure it ...
12 years, 9 months ago (2011-07-12 12:55:36 UTC) #1
Gabriel Charette
My patch at http://codereview.appspot.com/4657092/ was fixing this. Did you apply that already? I didn't see ...
12 years, 9 months ago (2011-07-12 18:02:37 UTC) #2
Diego Novillo
12 years, 9 months ago (2011-07-12 18:12:58 UTC) #3
On Tue, Jul 12, 2011 at 14:02, Gabriel Charette <gchare@google.com> wrote:
> My patch at http://codereview.appspot.com/4657092/ was fixing this.
>
> Did you apply that already? I didn't see it as part of your commits to date?

Ah, so that was it.  No, it wasn't 4657092.  I think we both fixed
this independently.  I now have a variant of 4657092 in my tree, but
it's still causing other grief.  I should have it ready today.


Diego.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b