Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(172)

Issue 4697041: code review 4697041: go/build: make Nuke comment say what it does (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by brainman
Modified:
13 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go/build: make Nuke comment say what it does

Patch Set 1 #

Patch Set 2 : diff -r dfc3491409c2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r dfc3491409c2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r dfc3491409c2 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 93ec1331584e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/go/build/build.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 10 months ago (2011-07-12 02:56:20 UTC) #1
brainman
I'm not certain on semantics of Nuke. Perhaps comment is correct, and we need to ...
13 years, 10 months ago (2011-07-12 02:56:53 UTC) #2
rsc
I think the old comment was right except for s/Clean/Nuke/. Note that it calls Clean ...
13 years, 10 months ago (2011-07-12 03:00:03 UTC) #3
brainman
On 2011/07/12 03:00:03, rsc wrote: > ... Note that it calls Clean > at the ...
13 years, 10 months ago (2011-07-12 03:06:30 UTC) #4
rsc
LGTM
13 years, 10 months ago (2011-07-12 03:06:52 UTC) #5
brainman
13 years, 10 months ago (2011-07-12 03:08:28 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=6b9301cc45ce ***

go/build: make Nuke comment say what it does

R=rsc
CC=golang-dev
http://codereview.appspot.com/4697041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b