Issue 4695060: code review 4695060: mime: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4695060: code review 4695060: mime: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by rsc

Modified:
13 years, 9 months ago

Reviewers:
brainman

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

mime: fix build

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/mime/type.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 9 months ago (2011-07-14 03:04:10 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=bd049019f550 *** mime: fix build R=bradfitz CC=golang-dev http://codereview.appspot.com/4695060

13 years, 9 months ago (2011-07-14 03:04:15 UTC) #2

bradfitz

13 years, 9 months ago (2011-07-14 04:19:44 UTC) #4

LGTM

On Wed, Jul 13, 2011 at 8:04 PM, <rsc@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> mime: fix build
>
> Please review this at
http://codereview.appspot.com/**4695060/<http://codereview.appspot.com/4695060/>
>
> Affected files:
>  M src/pkg/mime/type.go
>
>
> Index: src/pkg/mime/type.go
> ==============================**==============================**=======
> --- a/src/pkg/mime/type.go
> +++ b/src/pkg/mime/type.go
> @@ -19,7 +19,7 @@
>  }
>
>  var mimeTypes = map[string]string{
> -       ".css":  "text/css",
> +       ".css":  "text/css; charset=utf-8",
>        ".gif":  "image/gif",
>        ".htm":  "text/html; charset=utf-8",
>        ".html": "text/html; charset=utf-8",
>
>
>

Expand All Messages | Collapse All Messages