Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 4693046: Fix #1507: Inconsistent \festival output in regression testing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Neil Puttock
Modified:
12 years, 9 months ago
Reviewers:
Keith
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix #1507: Inconsistent \festival output in regression testing. * input/regression/song-skip-noword.ly reset *skip-word* to default at end of file to prevent override leaking into other regression tests * ly/festival.ly (festivalsyl): use paramaterize to set *syllabify* and limit its scope locally to the music function's body * scm/song.scm: make global configuration variables srfi-39 paramaters

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M input/regression/song-skip-noword.ly View 1 chunk +6 lines, -3 lines 0 comments Download
M ly/festival.ly View 2 chunks +12 lines, -7 lines 0 comments Download
M scm/song.scm View 8 chunks +19 lines, -20 lines 2 comments Download

Messages

Total messages: 4
Neil Puttock
12 years, 9 months ago (2011-07-12 21:48:03 UTC) #1
Keith
http://codereview.appspot.com/4693046/diff/1/scm/song.scm File scm/song.scm (right): http://codereview.appspot.com/4693046/diff/1/scm/song.scm#newcode222 scm/song.scm:222: #:unfinished (and (not (*syllabify*)) (find-child-named music 'HyphenEvent)) The regtest ...
12 years, 9 months ago (2011-07-16 04:59:50 UTC) #2
Keith
Works good for me. http://codereview.appspot.com/4693046/diff/1/scm/song.scm File scm/song.scm (right): http://codereview.appspot.com/4693046/diff/1/scm/song.scm#newcode222 scm/song.scm:222: #:unfinished (and (not (*syllabify*)) (find-child-named ...
12 years, 9 months ago (2011-07-16 05:42:36 UTC) #3
Neil Puttock
12 years, 9 months ago (2011-07-21 17:44:58 UTC) #4
On 2011/07/16 05:42:36, Keith wrote:
> Works good for me.

Thanks, pushed: 14632519690052980d19fc75e4dbc759c480aac2

Cheers,
Neil
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b