Issue 4691041: code review 4691041: exp/template: documentation glitches and typos.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4691041: code review 4691041: exp/template: documentation glitches and typos. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by r

Modified:
13 years, 10 months ago

Reviewers:

CC:
golang-dev, dsymonds, adg, r2

Visibility:
Public.

Description

exp/template: documentation glitches and typos. Also explain that len(v)==0 makes v a 'zero value' in template execution.

Patch Set 1 #

Patch Set 2 : diff -r 9e1ea214ad59 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9e1ea214ad59 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -10 lines)			Patch
	M	src/pkg/exp/template/doc.go	View	1	7 chunks	+18 lines, -6 lines	0 comments	Download
	M	src/pkg/exp/template/helper.go	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-07-11 04:27:59 UTC) #1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 10 months ago (2011-07-11 04:30:21 UTC) #2

On 11/07/2011, at 2:40 PM, adg@golang.org wrote: > LGTM > > I wanna go to ...

13 years, 10 months ago (2011-07-11 04:43:11 UTC) #5

13 years, 10 months ago (2011-07-11 04:43:28 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=2aade829de31 ***

exp/template: documentation glitches and typos.
Also explain that len(v)==0 makes v a 'zero value'
in template execution.

R=golang-dev, dsymonds, adg, r
CC=golang-dev
http://codereview.appspot.com/4691041

Expand All Messages | Collapse All Messages