code review 4689043: os: don't permit Process.Signal after a successful Wait

os: don't permit Process.Signal after a successful Wait

[bradfitz, 2011-07-11 22:12:36]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-07-11 22:31:17]

What if you wait with WNOHANG?
That can return with the process still executing.


Dave.

[bradfitz, 2011-07-11 22:33:44]

On Mon, Jul 11, 2011 at 3:30 PM, David Symonds <dsymonds@golang.org> wrote:

> What if you wait with WNOHANG?
> That can return with the process still executing.
>

I thought WNOHANG returned an error if it wasn't done yet?

[rsc, 2011-07-11 22:36:53]

david is right but meant wstopped

http://codereview.appspot.com/4689043/diff/4001/src/pkg/os/exec_unix.go
File src/pkg/os/exec_unix.go (right):

http://codereview.appspot.com/4689043/diff/4001/src/pkg/os/exec_unix.go#newco...
src/pkg/os/exec_unix.go:41: p.done = true
if options&WSTOPPED == 0 {
    p.done = true
}

[bradfitz, 2011-07-11 22:40:26]

Hello dsymonds@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2011-07-11 22:40:41]

Learn something new every day.  Never seen WSTOPPED.

On Mon, Jul 11, 2011 at 3:36 PM, <rsc@golang.org> wrote:

> david is right but meant wstopped
>
>
>
> http://codereview.appspot.com/**4689043/diff/4001/src/pkg/os/**
>
exec_unix.go<http://codereview.appspot.com/4689043/diff/4001/src/pkg/os/exec_unix.go>
> File src/pkg/os/exec_unix.go (right):
>
> http://codereview.appspot.com/**4689043/diff/4001/src/pkg/os/**
>
exec_unix.go#newcode41<http://codereview.appspot.com/4689043/diff/4001/src/pkg/os/exec_unix.go#newcode41>
> src/pkg/os/exec_unix.go:41: p.done = true
> if options&WSTOPPED == 0 {
>    p.done = true
>
> }
>
>
http://codereview.appspot.com/**4689043/<http://codereview.appspot.com/4689043/>
>

[rsc, 2011-07-11 22:42:33]

LGTM

[bradfitz, 2011-07-11 22:47:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=f4dbaa62bdf9 ***

os: don't permit Process.Signal after a successful Wait

R=dsymonds, rsc
CC=golang-dev
http://codereview.appspot.com/4689043

[iant2, 2011-07-11 23:23:04]

Brad Fitzpatrick <bradfitz@golang.org> writes:

> Learn something new every day.  Never seen WSTOPPED.

WSTOPPED == WUNTRACED.

Ian

[bradfitz, 2011-07-11 23:24:31]

On Mon, Jul 11, 2011 at 4:22 PM, Ian Lance Taylor <iant@google.com> wrote:

> Brad Fitzpatrick <bradfitz@golang.org> writes:
>
> > Learn something new every day.  Never seen WSTOPPED.
>
> WSTOPPED == WUNTRACED.
>

You should've saved that for tomorrow. Now I've learned two things in a
single day.