Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(252)

Issue 4678047: code review 4678047: exp/template: fields and methods on variables. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by r
Modified:
13 years, 10 months ago
Reviewers:
CC:
golang-dev, adg
Visibility:
Public.

Description

exp/template: fields and methods on variables. Not strictly necessary (you could achieve the same, clumsily, via with blocks) but great to have: $x.Field, $y.Method.

Patch Set 1 #

Patch Set 2 : diff -r 2aade829de31 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -18 lines) Patch
M src/pkg/exp/template/doc.go View 3 chunks +5 lines, -1 line 0 comments Download
M src/pkg/exp/template/exec.go View 5 chunks +21 lines, -8 lines 0 comments Download
M src/pkg/exp/template/exec_test.go View 2 chunks +4 lines, -0 lines 0 comments Download
M src/pkg/exp/template/lex.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/template/lex_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M src/pkg/exp/template/parse.go View 4 chunks +8 lines, -4 lines 0 comments Download
M src/pkg/exp/template/parse_test.go View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 10 months ago (2011-07-11 05:19:47 UTC) #1
adg
LGTM Yay!
13 years, 10 months ago (2011-07-11 05:23:03 UTC) #2
r
13 years, 10 months ago (2011-07-11 05:23:44 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=68e8a33745c1 ***

exp/template: fields and methods on variables.
Not strictly necessary (you could achieve the same, clumsily,
via with blocks) but great to have: $x.Field, $y.Method.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4678047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b