Issue 4675058: [api 1.5 branch] Fix JavaDoc to JsonCParser based on new usage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4675058: [api 1.5 branch] Fix JavaDoc to JsonCParser based on new usage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by yanivi

Modified:
14 years, 11 months ago

Reviewers:
jasonhall

Visibility:
Public.

Description

Fix JavaDoc to JsonCParser based on new usage and use HttpResponseException.getResponse().

Patch Set 1 #

Patch Set 2 : use HttpResponseException.getResponse() #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
M	google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/json/JsonCParser.java	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	google-api-client/src/test/java/com/google/api/client/googleapis/json/GoogleJsonErrorTest.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jasonhall

14 years, 11 months ago (2011-07-06 20:10:12 UTC) #2

LGTM

On Wed, Jul 6, 2011 at 3:35 PM, <yanivi@google.com> wrote:

> Reviewers: jasonhall,
>
>
>
> Please review this at
http://codereview.appspot.com/**4675058/<http://codereview.appspot.com/4675058/>
>
> Affected files:
>  M google-api-client/src/main/**java/com/google/api/client/**
> googleapis/json/JsonCParser.**java
>
>
> Index: google-api-client/src/main/**java/com/google/api/client/**
> googleapis/json/JsonCParser.**java
> ==============================**==============================**=======
> --- a/google-api-client/src/main/**java/com/google/api/client/**
> googleapis/json/JsonCParser.**java
> +++ b/google-api-client/src/main/**java/com/google/api/client/**
> googleapis/json/JsonCParser.**java
> @@ -39,10 +39,8 @@
>  *
>  * <pre>
>  * <code>
> -  static void setParser(HttpTransport transport) {
> -    JsonCParser parser = new JsonCParser();
> -    parser.jsonFactory = new JacksonFactory();
> -    transport.addParser(parser);
> +  static void setParser(HttpRequest request) {
> +    request.addParser(new JsonCParser(new JacksonFactory()));
>   }
>  * </code>
>  * </pre>
>
>
>

Expand All Messages | Collapse All Messages