Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1042)

Issue 4675048: correcting note about rerunning regtests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Janek Warchol
Modified:
12 years, 9 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

correcting note about rerunning regtests looks like it is necessary to make test-clean if you want to check regtests on a new branch without making test-baseline

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Documentation/contributor/regressions.itexi View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 7
Janek Warchol
12 years, 10 months ago (2011-07-05 07:49:44 UTC) #1
Reinhold
http://codereview.appspot.com/4675048/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/4675048/diff/1/Documentation/contributor/regressions.itexi#newcode276 Documentation/contributor/regressions.itexi:276: @code{make test-clean}, @code{make} and @code{make check} it without doing ...
12 years, 10 months ago (2011-07-05 13:20:13 UTC) #2
Janek Warchol
http://codereview.appspot.com/4675048/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/4675048/diff/1/Documentation/contributor/regressions.itexi#newcode276 Documentation/contributor/regressions.itexi:276: @code{make test-clean}, @code{make} and @code{make check} it without doing ...
12 years, 10 months ago (2011-07-06 17:50:08 UTC) #3
Graham Percival (old account)
LGTM
12 years, 10 months ago (2011-07-11 12:55:28 UTC) #4
Colin Campbell
This has had its countdown; please push and close.
12 years, 9 months ago (2011-07-14 04:06:29 UTC) #5
Janek Warchol
2011/7/14 <ColinPKCampbell@gmail.com>: > This has had its countdown; please push and close. I attach the ...
12 years, 9 months ago (2011-07-14 19:57:34 UTC) #6
Graham Percival
12 years, 9 months ago (2011-07-14 20:30:18 UTC) #7
On Thu, Jul 14, 2011 at 09:57:19PM +0200, Janek Warchoł wrote:
> I attach the patch; I've send it to Mike but he must have missed it.
> Anyone with push privileges - push it, please.

Thanks, pushed.

Cheers,
- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b