Issue 4674049: code review 4674049: runtime: eliminate false sharing on random number generators

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4674049: code review 4674049: runtime: eliminate false sharing on random number generators (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by dvyukov

Modified:
13 years, 10 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: eliminate false sharing on random number generators Use machine-local random number generator instead of racy global ones.

Patch Set 1 #

Patch Set 2 : diff -r f9725ff92a0c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f9725ff92a0c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f9725ff92a0c https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -29 lines)			Patch
M	src/pkg/runtime/chan.c	View	1	2 chunks	+2 lines, -13 lines	0 comments	Download
M	src/pkg/runtime/malloc.goc	View	1 2	2 chunks	+1 line, -16 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.c	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-07-11 13:02:49 UTC) #1

rsc

13 years, 10 months ago (2011-07-12 05:24:02 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=8e8bf76720e0 ***

runtime: eliminate false sharing on random number generators
Use machine-local random number generator instead of
racy global ones.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4674049

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages