code review 4672049: image: tighten Paletted.Opaque to only check those pale...

image: tighten Paletted.Opaque to check only those palette entries
in the image, not all palette entries.

[nigeltao, 2011-07-07 05:51:15]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-07-07 05:54:04]

LGTM but in CL s/to only check/to check/only/

http://codereview.appspot.com/4672049/diff/2001/src/pkg/image/image.go
File src/pkg/image/image.go (right):

http://codereview.appspot.com/4672049/diff/2001/src/pkg/image/image.go#newcod...
src/pkg/image/image.go:659: i1 += p.Stride
if you init them on one line, you should update them on one line. but you can't,
so i'd say just break the init into two lines.  it'd be easier to see how they
differ that way anyway

[nigeltao, 2011-07-07 06:30:08]

http://codereview.appspot.com/4672049/diff/2001/src/pkg/image/image.go
File src/pkg/image/image.go (right):

http://codereview.appspot.com/4672049/diff/2001/src/pkg/image/image.go#newcod...
src/pkg/image/image.go:659: i1 += p.Stride
On 2011/07/07 05:54:04, r wrote:
> if you init them on one line, you should update them on one line. but you
can't,
> so i'd say just break the init into two lines.  it'd be easier to see how they
> differ that way anyway

The initialization will change in a follow-up CL.

[nigeltao, 2011-07-07 06:32:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=f45a563c817e ***

image: tighten Paletted.Opaque to check only those palette entries
in the image, not all palette entries.

R=r
CC=golang-dev
http://codereview.appspot.com/4672049