changing shape of the G clef

changing shape of the G clef

makes upper loop smaller,
bottom crook sticks less,
vertical line is more evenly curved.
Also the upper loop is slightly bigger
in reduced version of the clef than
in the regular version, to fit stafflines well.

[Janek Warchol, 2011-07-08 23:58:34]

A tip to speed up work if you try to modify clef shape: use this script to
generate a dvi preview of glyphs (no need to run make, and it also shows
metafont control points):
#!/bin/bash
mf '\mode:=proof; input feta20'
 gftodvi feta20.2602gf \
 && mv feta20.dvi feta20new.proof.dvi

[Carl, 2011-07-09 00:03:39]

Please add an issue to the tracker, with images of both clefs, so we can see the
comparison side by side.  There should be pdf versions of both clefs, or
high-resolution images (1200 dpi or so).

Thanks,

Carl

[Janek Warchol, 2011-07-09 00:06:21]

2011/7/9  <Carl.D.Sorensen@gmail.com>:
> Please add an issue to the tracker, with images of both clefs, so we can
> see the comparison side by side.  There should be pdf versions of both
> clefs, or high-resolution images (1200 dpi or so).

http://code.google.com/p/lilypond/issues/detail?id=1752

i'll add some pdfs tomorrow, i hope that image attached will be
sufficient for now.

thanks,
Janek

[Janek Warchol, 2011-07-11 14:44:42]

New patch set uploaded - the suggested clef is a bit higher now.  Images can be
found in tracker issue: http://code.google.com/p/lilypond/issues/detail?id=1752

[Janek Warchol, 2011-07-16 19:03:43]

New patch set uploaded.

\override Staff.Clef #'style = #'old  tells Lily to use previous clef glyph
instead of my new clef.
(dedicated to James)

[t.daniels_treda.co.uk, 2011-07-16 20:57:15]

> \override Staff.Clef #'style = #'old  tells Lily to use previous 
> clef
> glyph instead of my new clef.
> (dedicated to James)

This is exactly the thin edge of the \override glyph
wedge I was worried about earlier :(  We already have
too many overrides.  If the majority want to change
the clef let's change it and ditch the legacy one,
just as we do with all the other changes.  If the
majority want to retain the old one we abandon the
new clef.  Trying to please everyone is the major
cause of excessive complexity in OS projects.

Trevor

[Janek Warchol, 2011-07-16 21:03:44]

2011/7/16 Trevor Daniels <t.daniels@treda.co.uk>:
>
>> \override Staff.Clef #'style = #'old  tells Lily to use previous clef
>> glyph instead of my new clef.
>> (dedicated to James)
>
> This is exactly the thin edge of the \override glyph
> wedge I was worried about earlier :(  We already have
> too many overrides.

I think we shouldn't delete it immediately.  We sometimes leave old
syntax for some time; let's keep old clef glyph until 2.18.  Then
we'll reconsider deleting it permanently.

cheers,
Janek

[Neil Puttock, 2011-07-17 21:09:44]

http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc
File lily/clef.cc (right):

http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc#newcode51
lily/clef.cc:51: str = str + "_" + clef_style;
you can't add clef_style unless you know glyph == "clefs.G"

[hanwenn, 2011-07-18 00:47:59]

2011/7/16 Janek Warchoł <lemniskata.bernoullego@gmail.com>:

>> This is exactly the thin edge of the \override glyph
>> wedge I was worried about earlier :(  We already have
>> too many overrides.
>
> I think we shouldn't delete it immediately.  We sometimes leave old
> syntax for some time; let's keep old clef glyph until 2.18.  Then
> we'll reconsider deleting it permanently.

It's only a glyph. We can just delete it directly.  That also helps
combat the inevitable code duplication between the MF code of the old
and new clef.

--
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

[Janek Warchol, 2011-07-23 14:25:10]

I guess this fixes the problem with "old" style for non-G clefs.

http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc
File lily/clef.cc (right):

http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc#newcode51
lily/clef.cc:51: str = str + "_" + clef_style;
On 2011/07/17 21:09:45, Neil Puttock wrote:
> you can't add clef_style unless you know glyph == "clefs.G"

Done.

[Janek Warchol, 2011-07-27 21:09:19]

Going back to replacing the clef only.  Old glyph is no longer in the patch, we
may discuss it separately.

[Janek Warchol, 2011-08-22 07:52:52]

pushed as e795110331497fbf46a7d61ed6ed73a9da4ae9c5