Add feta-flags to build system

Add feta-flags to build system

Put noteheads and flags in different fonts, but have them both
built at the same time, so black_notehead_width can be common
across both files.

If either font changes, both will be rebuilt, but only one rebuild
should happen.

[Carl, 2011-06-25 04:05:29]

Here is a revision of Janek's patch to separate feta-flags from feta-noteheads. 

I believe that it works properly; I rebuilt the fonts and the flags look fine.

To test, you will need to do

rm mf/out/* && make

before testing a lilypond file.

[Graham Percival (old account), 2011-06-25 16:48:51]

looks decent

[MikeSol, 2011-06-25 18:42:09]

LGTM - is there any way to get this in a pixel comparator w/ the previous flags
just to be certain that it doesn't cause any problems to the flags.  The last
time I reviewed a flag-related patch, I gave it the green light only to find
that I was failing to see some slight but important variations.

Cheers,
MS

http://codereview.appspot.com/4662055/diff/1/mf/feta-flags-generic.mf
File mf/feta-flags-generic.mf (right):

http://codereview.appspot.com/4662055/diff/1/mf/feta-flags-generic.mf#newcode5
mf/feta-flags-generic.mf:5: %
Change to Janek's name.

[Janek Warchol, 2011-06-25 19:17:52]

Carl!

Woot! It works! I compiled it twice, and everything looks fine!!
I told you you are a genious, didn't i? :D
Do i understand correctly that a variable is available to all fonts
(fet_beginfont ... fet_endfont) which are in the same mf file - it's so simple?
So you solved the problem by calling noteheads and flags together, but there had
to be two separate mf files so that there will be two separate "fonts", and
that's why this stuff is doubled?

http://codereview.appspot.com/4662055/diff/1/mf/GNUmakefile
File mf/GNUmakefile (right):

http://codereview.appspot.com/4662055/diff/1/mf/GNUmakefile#newcode20
mf/GNUmakefile:20: $(call src-wildcard,feta-flags*[0-9].mf) \
What does this exactly mean? Is it simply "feta-flags11.mf, feta-flags13.mf (and
so on) should be processed when make is called"?

http://codereview.appspot.com/4662055/diff/1/mf/bigcheese.pe.in
File mf/bigcheese.pe.in (right):

http://codereview.appspot.com/4662055/diff/1/mf/bigcheese.pe.in#newcode14
mf/bigcheese.pe.in:14: MergeFonts("feta-flags20.pfa");
This glues the fonts together,, but only after everything else was calculated?
Why only design size 20 appears here?

http://codereview.appspot.com/4662055/diff/1/mf/feta-flags-generic.mf
File mf/feta-flags-generic.mf (right):

http://codereview.appspot.com/4662055/diff/1/mf/feta-flags-generic.mf#newcode36
mf/feta-flags-generic.mf:36: %%    including feta-noteheads.
I suggest adding a warning "Be aware! The value 1.0 staff space is a dummy
value, not connected to the actual width of the notehead" to this comment. It's
easy to be fooled at the beginning.

http://codereview.appspot.com/4662055/diff/1/mf/feta-noteheads-generic.mf
File mf/feta-noteheads-generic.mf (right):

http://codereview.appspot.com/4662055/diff/1/mf/feta-noteheads-generic.mf#new...
mf/feta-noteheads-generic.mf:36: %%    including feta-noteheads.
I suggest adding a warning "Be aware! The value 1.0 staff space is a dummy
value, not connected to the actual width of the notehead" to this comment. It's
easy to be fooled at the beginning.

[mail_philholmes.net, 2011-06-25 20:21:37]

----- Original Message ----- 
From: <mtsolo@gmail.com>
To: <Carl.D.Sorensen@gmail.com>; <lemniskata.bernoullego@gmail.com>; 
<percival.music.ca@gmail.com>
Cc: <reply@codereview.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Saturday, June 25, 2011 7:42 PM
Subject: Re: Add feta-flags to build system (issue4662055)


> LGTM - is there any way to get this in a pixel comparator w/ the
> previous flags just to be certain that it doesn't cause any problems to
> the flags.  The last time I reviewed a flag-related patch, I gave it the
> green light only to find that I was failing to see some slight but
> important variations.


The simplest way I know would be to get a mingw version and send it to me. 
If that's not possible I'd have to try to find a way to use an Ubuntu 
version with my comparator - but I think that would be quite a bit of work.

--
Phil Holmes

[PhilEHolmes, 2011-06-28 08:29:54]

Minor comment.

http://codereview.appspot.com/4662055/diff/1/mf/GNUmakefile
File mf/GNUmakefile (left):

http://codereview.appspot.com/4662055/diff/1/mf/GNUmakefile#oldcode19
mf/GNUmakefile:19: $(call src-wildcard,feta-notehead*[0-9].mf) \
I'm assuming this is an old line of make, but I think to be correct,
feta-notehead* should be feta-noteheads*?

[Graham Percival, 2011-06-28 09:08:00]

On Tue, Jun 28, 2011 at 08:29:55AM +0000, PhilEHolmes@googlemail.com wrote:
> http://codereview.appspot.com/4662055/diff/1/mf/GNUmakefile#oldcode19
> mf/GNUmakefile:19: $(call src-wildcard,feta-notehead*[0-9].mf) \
> I'm assuming this is an old line of make, but I think to be correct,
> feta-notehead* should be feta-noteheads*?

feta-notehead* will include everything caught by feta-noteheads*

Are there any filenames like feta-noteheada* that we don't want to
catch?  (I agree that the name change would make it easier to
understand, though)


Actually, wait a moment.  Why not make it
  feta-noteheads[0-9][0-9].mf
?  That would be a bit more specific (and thus safer)

Cheers,
- Graham

[Carl, 2011-07-03 02:00:47]

This patch is broken, even though it appears to work.  feta-noteheads and
feta-flags share the same code-point space, so it's as if the two were never
split.

This patch will be abandoned and closed once I get my new try.