Fix for issue 1706.

Fix for issue 1706.

[MikeSol, 2011-06-23 14:00:23]

I think this'll do it.

Cheers,
MS

[Carl, 2011-06-23 16:48:15]

LGTM

[hanwenn, 2011-06-23 17:48:23]

* Test missing.
* Should print programming_error if dir == CENTER.
* I'd use linear_combination on dir instead, so it is symmetric in up/down.

On Thu, Jun 23, 2011 at 11:00 AM,  <mtsolo@gmail.com> wrote:
> Reviewers: ,
>
> Message:
> I think this'll do it.
>
> Cheers,
> MS
>
> Description:
> Fix for issue 1706.
>
> Please review this at http://codereview.appspot.com/4662047/
>
> Affected files:
>  M lily/beam.cc
>
>
> Index: lily/beam.cc
> diff --git a/lily/beam.cc b/lily/beam.cc
> index
>
8a30752c386eccd8294b181c5dd18159c2b492d2..e9ab3540b62318c1426f72bf36d2bdd008119482
> 100644
> --- a/lily/beam.cc
> +++ b/lily/beam.cc
> @@ -555,6 +555,8 @@ Beam::print (SCM grob)
>   Spanner *me = unsmob_spanner (grob);
>   Grob *commonx = 0;
>   vector<Beam_segment> segments = get_beam_segments (me, &commonx);
> +  if (!segments.size ())
> +    return SCM_EOL;
>
>   Interval span;
>   if (normal_stem_count (me))
> @@ -974,7 +976,7 @@ Beam::no_visible_stem_positions (Grob *me, Interval
> default_value)
>     }
>
>   Direction dir = get_grob_direction (me);
> -  Real y = head_positions[dir]
> +  Real y = head_positions[dir ? dir : UP]
>     * 0.5 * Staff_symbol_referencer::staff_space (me)
>     + dir * get_beam_translation (me) * (multiplicity.length () + 1);
>
>
>
>
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/lilypond-devel
>



-- 
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

[MikeSol, 2011-06-24 06:22:48]

On 2011/06/23 17:48:23, hanwenn wrote:
> * Test missing.
> * Should print programming_error if dir == CENTER.
> * I'd use linear_combination on dir instead, so it is symmetric in up/down.
> 

Done, done, and done.

Cheers,
MS

[pkx166h, 2011-06-24 15:51:14]

On 2011/06/24 06:22:48, MikeSol wrote:
> On 2011/06/23 17:48:23, hanwenn wrote:
> > * Test missing.
> > * Should print programming_error if dir == CENTER.
> > * I'd use linear_combination on dir instead, so it is symmetric in up/down.
> > 
> 
> Done, done, and done.
> 
> Cheers,
> MS

Mike I ran a reg test against this new beam code and I get significant
differences on

test-output-distance.ly

[James.Lowe_datacore.com, 2011-06-24 15:58:36]

Oops
________________________________________
From: lilypond-devel-bounces+james.lowe=datacore.com@gnu.org
[lilypond-devel-bounces+james.lowe=datacore.com@gnu.org] on behalf of
pkx166h@gmail.com [pkx166h@gmail.com]
Sent: 24 June 2011 16:51
To: mtsolo@gmail.com; carl.d.sorensen@gmail.com; hanwenn@gmail.com
Cc: reply@codereview.appspotmail.com; lilypond-devel@gnu.org
Subject: Re: Fix for issue 1706. (issue4662047)

On 2011/06/24 06:22:48, MikeSol wrote:
> On 2011/06/23 17:48:23, hanwenn wrote:
> > * Test missing.
> > * Should print programming_error if dir == CENTER.
> > * I'd use linear_combination on dir instead, so it is symmetric in
up/down.
> >

> Done, done, and done.

> Cheers,
> MS

Mike I ran a reg test against this new beam code and I get significant
differences on

test-output-distance.ly

----

Sorry Mike (and everyone)

I misread the CG. That one always changes :")

Otherwise ok.

james

[Graham Percival (old account), 2011-06-24 15:59:23]

On 2011/06/24 15:51:14, J_lowe wrote:
> Mike I ran a reg test against this new beam code and I get significant
> differences on
> 
> test-output-distance.ly

Umm...
http://lilypond.org/doc/v2.15/Documentation/contributor/regtest-comparison
... maybe we should change the background of @warning{} boxes to be #F00 ?


That said, this patch apparently removes 5
  warning: MIDI channel wrapped around
  warning: remapping modulo 16
which seems weird to me.  But hey, it's removing a misleading-looking warning,
so that's a good thing, right?  :)

Cheers,
- Graham

[mike_apollinemike.com, 2011-06-25 17:13:11]

On Jun 24, 2011, at 5:58 PM, James Lowe wrote:

> Oops
> ________________________________________
> From: lilypond-devel-bounces+james.lowe=datacore.com@gnu.org
[lilypond-devel-bounces+james.lowe=datacore.com@gnu.org] on behalf of
pkx166h@gmail.com [pkx166h@gmail.com]
> Sent: 24 June 2011 16:51
> To: mtsolo@gmail.com; carl.d.sorensen@gmail.com; hanwenn@gmail.com
> Cc: reply@codereview.appspotmail.com; lilypond-devel@gnu.org
> Subject: Re: Fix for issue 1706. (issue4662047)
> 
> On 2011/06/24 06:22:48, MikeSol wrote:
>> On 2011/06/23 17:48:23, hanwenn wrote:
>>> * Test missing.
>>> * Should print programming_error if dir == CENTER.
>>> * I'd use linear_combination on dir instead, so it is symmetric in
> up/down.
>>> 
> 
>> Done, done, and done.
> 
>> Cheers,
>> MS
> 
> Mike I ran a reg test against this new beam code and I get significant
> differences on
> 
> test-output-distance.ly
> 
> ----
> 
> Sorry Mike (and everyone)
> 
> I misread the CG. That one always changes :")
> 
> Otherwise ok.
> 
> james

Thanks to both of you for running the regtests.

Pushed as 7bcdd37be15ece09cd97841137b075a576bbe696.

Cheers,
MS