Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2182)

Issue 4657082: code review 4657082: exp/template: replace the lexer's item channel with an ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by nigeltao
Modified:
12 years, 9 months ago
Reviewers:
r
CC:
golang-dev
Visibility:
Public.

Description

exp/template: replace the lexer's item channel with an inline ringbuffer, saving a separate allocation.

Patch Set 1 #

Patch Set 2 : diff -r 6998f26de587 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6998f26de587 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -19 lines) Patch
M src/pkg/exp/template/lex.go View 1 4 chunks +25 lines, -19 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2011-07-08 00:09:05 UTC) #1
r
no. i admit this might be faster, but not because of allocation. if the init ...
12 years, 9 months ago (2011-07-08 00:49:19 UTC) #2
nigeltao
12 years, 9 months ago (2011-07-08 01:07:14 UTC) #3
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b