Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 4654077: code review 4654077: goprotobuf: Changes for new struct tag format. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by dsymonds
Modified:
14 years, 4 months ago
Reviewers:
CC:
r, rsc, golang-dev
Visibility:
Public.

Description

goprotobuf: Changes for new struct tag format. Protocol messages have changed their struct tags from "PB(...)" to `protobuf:"..."` The format represented by "..." is unchanged. Regenerate {descriptor,plugin}.pb.go files at the same time.

Patch Set 1 #

Patch Set 2 : diff -r dd857f0bb715 https://goprotobuf.googlecode.com/hg #

Patch Set 3 : diff -r dd857f0bb715 https://goprotobuf.googlecode.com/hg #

Patch Set 4 : diff -r dd857f0bb715 https://goprotobuf.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+958 lines, -873 lines) Patch
M compiler/descriptor/descriptor.pb.go View 1 9 chunks +241 lines, -227 lines 0 comments Download
M compiler/descriptor/descriptor.pb.golden View 1 9 chunks +241 lines, -227 lines 0 comments Download
M compiler/generator/generator.go View 1 4 chunks +4 lines, -4 lines 0 comments Download
M compiler/plugin/plugin.pb.go View 1 1 chunk +21 lines, -20 lines 0 comments Download
M compiler/plugin/plugin.pb.golden View 1 1 chunk +21 lines, -20 lines 0 comments Download
M compiler/testdata/test.pb.go.golden View 1 6 chunks +15 lines, -15 lines 0 comments Download
M proto/extensions.go View 1 1 chunk +1 line, -1 line 0 comments Download
M proto/lib.go View 1 2 chunks +5 lines, -5 lines 0 comments Download
M proto/message_set.go View 1 1 chunk +4 lines, -4 lines 0 comments Download
M proto/properties.go View 1 4 chunks +8 lines, -9 lines 0 comments Download
M proto/testdata/test.pb.go View 1 17 chunks +108 lines, -108 lines 0 comments Download
M proto/testdata/test.pb.go.golden View 1 2 chunks +288 lines, -232 lines 0 comments Download
M proto/text.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
dsymonds
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://goprotobuf.googlecode.com/hg
14 years, 4 months ago (2011-07-01 02:56:00 UTC) #1
dsymonds
Note that this does *not* include adding the json: tag. I'll do that separately.
14 years, 4 months ago (2011-07-01 02:58:44 UTC) #2
rsc
LGTM I didn't look closely at the generated files.
14 years, 4 months ago (2011-07-01 14:15:06 UTC) #3
dsymonds
Rob, are you happy with this change?
14 years, 4 months ago (2011-07-04 05:33:25 UTC) #4
r
LGTM
14 years, 4 months ago (2011-07-04 05:42:18 UTC) #5
dsymonds
14 years, 4 months ago (2011-07-04 05:53:24 UTC) #6
*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=89e4e9b61919 ***

goprotobuf: Changes for new struct tag format.

Protocol messages have changed their struct tags from
  "PB(...)"
to
  `protobuf:"..."`
The format represented by "..." is unchanged.

Regenerate {descriptor,plugin}.pb.go files at the same time.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/4654077
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b