code review 4654069: mime: media type formatter

mime: media type formatter

[pascal, 2011-06-28 00:06:17]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[pascal, 2011-06-28 20:52:50]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[pascal, 2011-07-06 16:23:53]

On Tuesday 28 June 2011 22:52:50 pascal@quies.net wrote:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
> 
> Please take another look.
> 
> 
> http://codereview.appspot.com/4654069/

ping

[nigeltao, 2011-07-07 01:47:45]

On Tuesday 28 June 2011 22:52:50 pascal@quies.net wrote:
> http://codereview.appspot.com/4654069/

I think bradfitz would be the guy to review this, but he's on vacation
this week.

[rsc, 2011-07-13 22:57:19]

R=bradfitz

What is this code for?
Is it just so that the existing code can
add ; charset=utf-8?  That seems easier
to do with +=.

Please read http://golang.org/doc/effective_go.html#commentary
and update your comments.

[bradfitz, 2011-07-13 23:07:01]

I could imagine this being useful for MIME-ish stuff.

http://codereview.appspot.com/4654069/diff/6001/src/pkg/mime/mediatype.go
File src/pkg/mime/mediatype.go (right):

http://codereview.appspot.com/4654069/diff/6001/src/pkg/mime/mediatype.go#new...
src/pkg/mime/mediatype.go:24: buffer := bytes.NewBuffer(make([]byte, 0, 48))
You can just do:

var buf bytes.Buffer

a bytes.Buffer has 64 freebie byes inside of it that it can use without doing
any allocations.  you doing make([]byte, 0, 48) is trying to be efficient, but
is actually doing more work.

[pascal, 2011-07-14 20:06:11]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-08-26 20:51:57]

LGTM

Sorry for the long delay.

[rsc, 2011-08-26 20:55:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=e96d0b4b19c6 ***

mime: media type formatter

R=bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/4654069

Committer: Russ Cox <rsc@golang.org>