Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(866)

Issue 4654063: Small pitch bends correct and tested. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by Janek Warchol
Modified:
12 years, 8 months ago
Reviewers:
Keith, cpkc, gbreed, carl.d.sorensen, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Small pitch bends correct and tested. Pitch bends are not rounded to cents. Pitch bends of full precision centered on zero.

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M lily/midi-item.cc View 1 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 13
Janek Warchol
Graham Breed wrote: I've found and patched two problems with the pitch bend tuning code: ...
12 years, 9 months ago (2011-06-25 20:13:04 UTC) #1
cpkc_shaw.ca
On 11-06-25 02:13 PM, lemniskata.bernoullego@gmail.com wrote: > Graham Breed wrote: > > I've found and ...
12 years, 9 months ago (2011-06-25 22:50:17 UTC) #2
Keith
Looks, and sounds, good to me.
12 years, 9 months ago (2011-06-26 06:52:37 UTC) #3
gbreed
Colin Campbell <cpkc@shaw.ca> wrote: > Thanks for this, Graham! I've added this to the tracker ...
12 years, 9 months ago (2011-06-26 09:38:57 UTC) #4
Neil Puttock
LGTM. http://codereview.appspot.com/4654063/diff/1/lily/midi-item.cc File lily/midi-item.cc (right): http://codereview.appspot.com/4654063/diff/1/lily/midi-item.cc#newcode202 lily/midi-item.cc:202: + audio_->transposing_.tone_pitch ()) * Rational (2)); indent: ((audio_ ...
12 years, 9 months ago (2011-06-26 13:13:50 UTC) #5
Carl
LGTM, with Neil's comments taken Carl
12 years, 9 months ago (2011-07-05 05:19:45 UTC) #6
Janek Warchol
Graham, I'm worried that i don't hear anything from you since 2 weeks! Do you ...
12 years, 8 months ago (2011-07-10 21:48:34 UTC) #7
gbreed
lemniskata.bernoullego@gmail.com wrote: > Graham, > > I'm worried that i don't hear anything from you ...
12 years, 8 months ago (2011-07-11 09:55:19 UTC) #8
Janek Warchol
2011/7/11 Graham Breed <gbreed@gmail.com>: > Is that me? I'm supposed to do something? Here's a ...
12 years, 8 months ago (2011-07-11 18:02:39 UTC) #9
Neil Puttock
2011/7/11 Janek Warchoł <lemniskata.bernoullego@gmail.com>: > 2011/7/11 Graham Breed <gbreed@gmail.com>: >> Is that me? I'm supposed ...
12 years, 8 months ago (2011-07-11 19:14:43 UTC) #10
Janek Warchol
2011/7/11 Neil Puttock <n.puttock@gmail.com>: > 2011/7/11 Janek Warchoł <lemniskata.bernoullego@gmail.com>: >> 2011/7/11 Graham Breed <gbreed@gmail.com>: >>> ...
12 years, 8 months ago (2011-07-11 19:52:32 UTC) #11
Neil Puttock
2011/7/11 Janek Warchoł <lemniskata.bernoullego@gmail.com>: > Sorry, i didn't notice. > Attached is a nicely described ...
12 years, 8 months ago (2011-07-11 20:37:56 UTC) #12
Janek Warchol
12 years, 8 months ago (2011-07-11 20:44:27 UTC) #13
2011/7/11 Neil Puttock <n.puttock@gmail.com>:
> Thanks, pushed to master.

Thanks, issue closed.

cheers,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b