code review 4652041: test: test of goto restrictions

test: test of goto restrictions

[rsc, 2011-06-17 19:03:05]

Hello gri, iant (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-06-17 19:11:16]

LGTM

nice tests!

http://codereview.appspot.com/4652041/diff/7001/test/errchk
File test/errchk (right):

http://codereview.appspot.com/4652041/diff/7001/test/errchk#newcode85
test/errchk:85: # Turn relative line number in message into absolute line
number.
nice

[rsc, 2011-06-17 19:20:25]

Hello gri@golang.org, iant@golang.org, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[gri, 2011-06-17 19:20:39]

LGTM

very nice

http://codereview.appspot.com/4652041/diff/7001/test/goto.go
File test/goto.go (right):

http://codereview.appspot.com/4652041/diff/7001/test/goto.go#newcode238
test/goto.go:238: // really is LINE+1, even though that looks wrong at first.
it's really the same as the previous test

[fvb, 2011-06-17 19:41:48]

http://codereview.appspot.com/4652041/diff/12001/test/errchk
File test/errchk (right):

http://codereview.appspot.com/4652041/diff/12001/test/errchk#newcode86
test/errchk:86: if($regexp =~ /LINE(([+-])([0-9+]))?/) {
Don't you mean [0-9]+ instead of [0-9+]?

[r, 2011-06-17 22:18:05]

LGTM after the regexp fix

makes me wonder if the word to use in the spec for this isn't "block" but
"scope"

[iant, 2011-06-17 22:46:07]

LGTM

[rsc, 2011-06-20 18:06:05]

*** Submitted as http://code.google.com/p/go/source/detail?r=9abbe41e91ff ***

test: test of goto restrictions

R=gri, iant, bradfitz, fvbommel, r
CC=golang-dev
http://codereview.appspot.com/4652041