code review 4650062: misc/vim: allow only utf-8 for fileencoding (fix CL462...

misc/vim:  allow only utf-8 for fileencoding (fix CL4625078).

[mattn, 2011-06-30 06:39:39]

Sorry about previous change in 'misc/vim'.
I hope that this get few reviewers.

[mattn, 2011-06-30 06:40:22]

Hello golang-dev@googlecode.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
http://go.googlecode.com/hg/

[dsymonds, 2011-06-30 06:46:38]

http://codereview.appspot.com/4650062/diff/6001/misc/vim/ftdetect/gofiletype.vim
File misc/vim/ftdetect/gofiletype.vim (right):

http://codereview.appspot.com/4650062/diff/6001/misc/vim/ftdetect/gofiletype....
misc/vim/ftdetect/gofiletype.vim:2: au BufRead,BufNewFile *.go set filetype=go
This line should not be needed. BufReadPre is triggered in every case that
BufRead is, right?

[mattn, 2011-06-30 07:04:37]

http://codereview.appspot.com/4650062/diff/6001/misc/vim/ftdetect/gofiletype.vim
File misc/vim/ftdetect/gofiletype.vim (right):

http://codereview.appspot.com/4650062/diff/6001/misc/vim/ftdetect/gofiletype....
misc/vim/ftdetect/gofiletype.vim:2: au BufRead,BufNewFile *.go set filetype=go
On 2011/06/30 06:46:39, dsymonds wrote:
> This line should not be needed. BufReadPre is triggered in every case that
> BufRead is, right?

Done.

[dsymonds, 2011-06-30 07:07:02]

LGTM

[mattn, 2011-06-30 07:07:08]

PTAL

open existing utf-8 file:
  :set fileencoding? fileencodings?
  fileencoding=utf-8
  fileencodings=utf-8

  OK

make new buffer:
  :set fileencoding? fileencodings?
  fileencoding=utf-8
  fileencodings=utf-8

  OK


Probably, latest is good for me. :)

On 2011/06/30 07:04:37, mattn wrote:
>
http://codereview.appspot.com/4650062/diff/6001/misc/vim/ftdetect/gofiletype.vim
> File misc/vim/ftdetect/gofiletype.vim (right):
> 
>
http://codereview.appspot.com/4650062/diff/6001/misc/vim/ftdetect/gofiletype....
> misc/vim/ftdetect/gofiletype.vim:2: au BufRead,BufNewFile *.go set filetype=go
> On 2011/06/30 06:46:39, dsymonds wrote:
> > This line should not be needed. BufReadPre is triggered in every case that
> > BufRead is, right?
> 
> Done.

[dsymonds, 2011-06-30 07:07:51]

*** Submitted as http://code.google.com/p/go/source/detail?r=fcb55e9457d8 ***

misc/vim:  allow only utf-8 for fileencoding (fix CL4625078).

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4650062

Committer: David Symonds <dsymonds@golang.org>