Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 4648068: code review 4648068: [release-branch.r58] ld: dwarf emit filenames in debug_... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by adg
Modified:
13 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

[release-branch.r58] ld: dwarf emit filenames in debug_line header instead of as extended opcodes. ««« CL 4609043 / caaab1e64d49 ld: dwarf emit filenames in debug_line header instead of as extended opcodes. Makes it possible for older tools like objdump to find the filenames, fixes objdump -d -l --start-address=0x400c00 --stop-address=0x400c36 6.out fixes issue 1950 R=rsc CC=golang-dev http://codereview.appspot.com/4609043 »»»

Patch Set 1 #

Patch Set 2 : diff -r e4c6b6936d8f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M src/cmd/ld/dwarf.c View 1 8 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 3
adg
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 10 months ago (2011-06-29 05:38:53 UTC) #1
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=3cf2e96881ac *** [release-branch.r58] ld: dwarf emit filenames in debug_line header instead of ...
13 years, 10 months ago (2011-06-29 05:39:02 UTC) #2
rsc
13 years, 10 months ago (2011-06-29 05:40:13 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b