code review 4648049: exec: better error message for windows LookPath

exec: better error message for windows LookPath

Fixes issue 1991.

[brainman, 2011-06-22 07:28:30]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitzgoog, 2011-06-22 16:00:01]

Why is there an ErrNotFound in the first place, then?

It seems path searching is a bit different than ENOENT.

I looked at 1991 but don't understand the desired behavior enough to say
whether this is right or not.


On Wed, Jun 22, 2011 at 12:28 AM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> exec: better error message for windows LookPath
>
> Fixes issue 1991.
>
> Please review this at
http://codereview.appspot.com/**4648049/<http://codereview.appspot.com/4648049/>
>
> Affected files:
>  M src/pkg/exec/lp_windows.go
>
>
> Index: src/pkg/exec/lp_windows.go
> ==============================**==============================**=======
> --- a/src/pkg/exec/lp_windows.go
> +++ b/src/pkg/exec/lp_windows.go
> @@ -38,7 +38,7 @@
>                        return f, nil
>                }
>        }
> -       return ``, ErrNotFound
> +       return ``, os.ENOENT
>  }
>
>  func LookPath(file string) (f string, err os.Error) {
>
>
>

[rsc, 2011-06-22 20:19:47]

LGTM

On Wed, Jun 22, 2011 at 11:59, Brad Fitzpatrick <bradfitz@google.com> wrote:
> Why is there an ErrNotFound in the first place, then?
> It seems path searching is a bit different than ENOENT.

Windows is weird (of course).
This error gets shown only when the path given
contains a \, so it is not subject to %PATH%
searches.  It is still subject to an extension
search but I think it's okay to gloss over that
in the error.

Russ

[brainman, 2011-06-22 23:16:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=acba2aaede28 ***

exec: better error message for windows LookPath

Fixes issue 1991.

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/4648049