Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75)

Issue 4646047: code review 4646047: Make.ccmd: another build fix. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by r
Modified:
13 years, 11 months ago
Reviewers:
r2
CC:
Joe Poirier, golang-dev
Visibility:
Public.

Description

Make.ccmd: another build fix. It's sad to think there are environments where compiling against a library isn't enough information for the the linker to decide that you need that library. TBR=jdpoirier

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/Make.ccmd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
r
Hello jdpoirier@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 11 months ago (2011-06-19 05:30:52 UTC) #1
r
*** Submitted as http://code.google.com/p/go/source/detail?r=f967b37706e1 *** Make.ccmd: another build fix. It's sad to think there are ...
13 years, 11 months ago (2011-06-19 05:31:02 UTC) #2
Joe Poirier
On Jun 19, 2011, at Jun 19 - 12:31 AM, r@golang.org wrote: > *** Submitted ...
13 years, 11 months ago (2011-06-19 05:52:29 UTC) #3
r2
On 19/06/2011, at 3:52 PM, Joseph Poirier wrote: > On Jun 19, 2011, at Jun ...
13 years, 11 months ago (2011-06-19 06:00:17 UTC) #4
Joe Poirier
13 years, 11 months ago (2011-06-19 06:08:34 UTC) #5
On Jun 19, 2011, at Jun 19 - 1:00 AM, Rob 'Commander' Pike wrote:

> 
> On 19/06/2011, at 3:52 PM, Joseph Poirier wrote:
> 
>> On Jun 19, 2011, at Jun 19 - 12:31 AM, r@golang.org wrote:
>> 
>>> *** Submitted as
>>> http://code.google.com/p/go/source/detail?r=f967b37706e1 ***
>>> 
>>> Make.ccmd: another build fix.
>>> It's sad to think there are environments where compiling against a
>>> library
>>> isn't enough information for the the linker to decide that you need that
>>> library.
>>> TBR=jdpoirier
>>> 
>>> R=jdpoirier
>>> CC=golang-dev
>>> http://codereview.appspot.com/4646047
>>> 
>>> 
>>> http://codereview.appspot.com/4646047/
>> 
>> Sorry for the troubles!  
>> 
>> What library does -lm refer to? When I build the tool-chain using tcc it
fails because it can't find the lib file referred to by -lm. Would including
math.h have worked to resolve the missing reference to floor?
> 
> -lm is the library for math.h. The reference is needed by the linker and Unix
C tools are too feebleminded to figure out that if I use math.h I need -lm.
> 
> -rob

Much appreciated... 

I guess there are inconsistencies with gcc across platforms; both OSX and
Windows didn't seem to have a problem.

-joe
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b