Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2427)

Issue 4645077: Add display method for \tweak (fixes issue 1733) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Neil Puttock
Modified:
12 years, 9 months ago
Reviewers:
pkx166h, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add display method for \tweak. * input/regression/display-lily-tests.ly: add tests for \tweak * scm/define-music-display-methods.scm (scheme-expr->lily-string): don't funnel booleans through pretty-print (EventChord): treat simple_element with 'tweaks list as note_chord_element to preserve < > around tweaked note * scm/display-lily.scm (music->lily-string): process 'tweaks via new function music->lily-string

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M input/regression/display-lily-tests.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M scm/define-music-display-methods.scm View 2 chunks +5 lines, -2 lines 0 comments Download
M scm/display-lily.scm View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Neil Puttock
This patch allows \tweak to be displayed properly when using \displayLilyMusic. * scm/display-lily.scm (music->lily-string): process ...
12 years, 10 months ago (2011-07-03 21:59:56 UTC) #1
pkx166h
Reg tests pass and no make problems James
12 years, 10 months ago (2011-07-04 00:04:08 UTC) #2
Carl
LGTM Carl
12 years, 9 months ago (2011-07-05 03:48:46 UTC) #3
Neil Puttock
12 years, 9 months ago (2011-07-07 19:23:04 UTC) #4
On 5 July 2011 04:48,  <Carl.D.Sorensen@gmail.com> wrote:
> LGTM

Thanks, Carl.

Pushed: d5766025a1573c709dfa3c9663c1c6b903abec24
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b