Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2861)

Issue 4645074: code review 4645074: build: make version.bash aware of branches (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by adg
Modified:
12 years, 10 months ago
Reviewers:
CC:
bradfitz, rsc, golang-dev
Visibility:
Public.

Description

build: make version.bash aware of branches Fixes issue 2026.

Patch Set 1 #

Patch Set 2 : diff -r f3daeb861002 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/version.bash View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 3
adg
Hello bradfitz, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 10 months ago (2011-06-30 04:58:31 UTC) #1
bradfitz
LGTM On Wed, Jun 29, 2011 at 9:58 PM, <adg@golang.org> wrote: > Reviewers: bradfitz, rsc, ...
12 years, 10 months ago (2011-06-30 05:03:48 UTC) #2
adg
12 years, 10 months ago (2011-06-30 05:39:11 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=dd31a3b56536 ***

build: make version.bash aware of branches

Fixes issue 2026.

R=bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/4645074
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b