Issue 4644052: code review 4644052: test: new nil semantics

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4644052: code review 4644052: test: new nil semantics (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by rsc

Modified:
13 years, 8 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 9abbe41e91ff https://go.googlecode.com/hg #

Patch Set 3 : diff -r f0b7999bc9a4 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 6b2fbe78d933 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 5 : diff -r 7519bd32912d https://go.googlecode.com/hg #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -0 lines)			Patch
	M	test/nil.go	View	1 2 3 4	2 chunks	+142 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 8 months ago (2011-08-17 18:54:34 UTC) #1

gri

LGTM but for the commented out chantest http://codereview.appspot.com/4644052/diff/9001/test/nil.go File test/nil.go (right): http://codereview.appspot.com/4644052/diff/9001/test/nil.go#newcode43 test/nil.go:43: // TODO ...

13 years, 8 months ago (2011-08-17 19:07:31 UTC) #2

rsc

> http://codereview.appspot.com/4644052/diff/9001/test/nil.go#newcode43 > test/nil.go:43: // TODO chantest() > looks like chantest is present below. remove ...

13 years, 8 months ago (2011-08-17 19:15:12 UTC) #3

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=5fa083fa94b9 *** test: new nil semantics R=gri CC=golang-dev http://codereview.appspot.com/4644052

13 years, 8 months ago (2011-08-17 19:55:09 UTC) #4

Submitted with chan test enabled.

Expand All Messages | Collapse All Messages