code review 4643068: exp/template: functions

exp/template: functions
Add the ability to attach functions to template and template sets.
Make variadic functions and methods work.
Still to come: static checking of function names during parse.

[r, 2011-07-05 03:54:20]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-07-05 03:55:29]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2011-07-05 04:17:04]

LGTM

http://codereview.appspot.com/4643068/diff/2001/src/pkg/exp/template/exec.go
File src/pkg/exp/template/exec.go (left):

http://codereview.appspot.com/4643068/diff/2001/src/pkg/exp/template/exec.go#...
src/pkg/exp/template/exec.go:279: case typ.NumOut() == 2 && typ.Out(1) ==
osErrorType:
This checking could be replicated in addFuncs so that named functions can be
statically checked before failing at evaluation time.

http://codereview.appspot.com/4643068/diff/2001/src/pkg/exp/template/parse.go
File src/pkg/exp/template/parse.go (right):

http://codereview.appspot.com/4643068/diff/2001/src/pkg/exp/template/parse.go...
src/pkg/exp/template/parse.go:462: // The return value is the template, so calls
can be chained; it will be
It won't be nil; the return value will always be t.

[r, 2011-07-05 04:24:02]

*** Submitted as http://code.google.com/p/go/source/detail?r=28048221b2a5 ***

exp/template: functions
Add the ability to attach functions to template and template sets.
Make variadic functions and methods work.
Still to come: static checking of function names during parse.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4643068