code review 4643057: runtime/cgo: check for errors from pthread_create

runtime/cgo: check for errors from pthread_create

[albert.strasheim, 2011-06-28 07:40:16]

Hello rsc@golang.org, iant@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[albert.strasheim, 2011-06-28 07:41:23]

On 2011/06/28 07:40:16, albert.strasheim wrote:
> Hello mailto:rsc@golang.org, mailto:iant@golang.org (cc:
mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

There are still two pthread_creates in libmach/darwin.c that don't check their
return values. Not sure what the best way is to fix those.

While I was in there, I also noticed quite a few printf missing arguments.

Regards

Albert

[dvyukov, 2011-06-28 09:42:13]

On 2011/06/28 07:40:16, albert.strasheim wrote:
> Hello mailto:rsc@golang.org, mailto:iant@golang.org (cc:
mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

I would suggest to output stringified errno as well.

[albert.strasheim, 2011-06-28 10:07:56]

Hello

On Tue, Jun 28, 2011 at 11:42 AM,  <dvyukov@google.com> wrote:
> On 2011/06/28 07:40:16, albert.strasheim wrote:
>> Hello mailto:rsc@golang.org, mailto:iant@golang.org (cc:
> mailto:golang-dev@googlegroups.com),
>> I'd like you to review this change to
>> https://go.googlecode.com/hg/
> I would suggest to output stringified errno as well.

I thought about that, but I'm not sure if strerror is safe to use in
this situation, or if I should use the functions in lib9/errstr.c?

Regards

Albert

[rsc, 2011-06-28 11:31:45]

> There are still two pthread_creates in libmach/darwin.c that don't check
> their return values. Not sure what the best way is to fix those.

Not the same way?

> While I was in there, I also noticed quite a few printf missing
> arguments.

Thanks.

[rsc, 2011-06-28 11:31:59]

> I thought about that, but I'm not sure if strerror is safe to use in
> this situation, or if I should use the functions in lib9/errstr.c?

The files you're editing are compiled by gcc.
You're already calling fprintf, so using strerror
should not be a problem.

Russ

[albert.strasheim, 2011-06-28 15:33:45]

Hello

On 2011/06/28 11:31:59, rsc wrote:
> > I thought about that, but I'm not sure if strerror is safe to use in
> > this situation, or if I should use the functions in lib9/errstr.c?
> The files you're editing are compiled by gcc.
> You're already calling fprintf, so using strerror
> should not be a problem.

Okay, done. PTAL.

I've tested that all.bash compiles and runs on linux/amd64 and darwin/amd64.

Regards

Albert

[rsc, 2011-06-28 16:05:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=0e960179c82e ***

runtime/cgo: check for errors from pthread_create

R=rsc, iant, dvyukov
CC=golang-dev
http://codereview.appspot.com/4643057

Committer: Russ Cox <rsc@golang.org>