Issue 4641099: code review 4641099: flag: make -help nicer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4641099: code review 4641099: flag: make -help nicer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by r

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

flag: make -help nicer. - suppress the print that -help is not defined. - return a special error code if -help is set - do not change behavior if an explict "help" flag is defined.

Patch Set 1 #

Patch Set 2 : diff -r 8746f9553924 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8f4f54086330 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -1 line)			Patch
	M	src/pkg/flag/flag.go	View	1 2	4 chunks	+15 lines, -1 line	0 comments	Download
	M	src/pkg/flag/flag_test.go	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-07-10 23:16:47 UTC) #1

On 11/07/2011, at 9:26 AM, dsymonds@golang.org wrote: > LGTM > > It'd be nice if ...

13 years, 9 months ago (2011-07-10 23:35:56 UTC) #3

13 years, 9 months ago (2011-07-10 23:35:58 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=77716b3c0b90 ***

flag: make -help nicer.
- suppress the print that -help is not defined.
- return a special error code if -help is set
- do not change behavior if an explict "help" flag is defined.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4641099

Expand All Messages | Collapse All Messages