Issue 4641097: Fix 750: No warning for non-found voice in lyrics combine when lyrics are empty

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4641097: Fix 750: No warning for non-found voice in lyrics combine when lyrics are empty (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by Reinhold

Modified:
12 years, 10 months ago

Reviewers:
carl.d.sorensen, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix 750: No warning for non-found voice in lyrics combine when lyrics are empty Use a bool flag to store whether the Lyrics context was ever really created (i.e. one moment was processed). If that's not the case, then the lyrics are empty, and we shouldn't print any warning about non-existing voices (since we never even tried to find an appropriate voice; and we also don't need one anyway). Fixes isse 750 (http://code.google.com/p/lilypond/issues/detail?id=750)

Patch Set 1 #

Total comments: 5

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -4 lines)			Patch
	A	input/regression/lyric-combine-empty-warning.ly	View		1 chunk	+23 lines, -0 lines	5 comments	Download
	M	lily/lyric-combine-music-iterator.cc	View		4 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Neil Puttock

12 years, 10 months ago (2011-07-10 21:14:02 UTC) #2

LGTM.

http://codereview.appspot.com/4641097/diff/1/input/regression/lyric-combine-e...
File input/regression/lyric-combine-empty-warning.ly (right):

http://codereview.appspot.com/4641097/diff/1/input/regression/lyric-combine-e...
input/regression/lyric-combine-empty-warning.ly:1: \version "2.15.4"
2.15.5

http://codereview.appspot.com/4641097/diff/1/input/regression/lyric-combine-e...
input/regression/lyric-combine-empty-warning.ly:3: \header{
\header {

http://codereview.appspot.com/4641097/diff/1/input/regression/lyric-combine-e...
input/regression/lyric-combine-empty-warning.ly:5: texidoc= "If lyrics are
assigned to a non-existing voice, a warning should
indent

texidoc =

http://codereview.appspot.com/4641097/diff/1/input/regression/lyric-combine-e...
input/regression/lyric-combine-empty-warning.ly:13: \new Staff
indent

http://codereview.appspot.com/4641097/diff/1/input/regression/lyric-combine-e...
input/regression/lyric-combine-empty-warning.ly:15: c1
indent

Expand All Messages | Collapse All Messages