code review 4641096: exp/template: the must-have MustParse functions

exp/template: the must-have MustParse functions

[adg, 2011-07-08 05:10:36]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-07-08 05:25:14]

http://codereview.appspot.com/4641096/diff/1/src/pkg/exp/template/parse.go
File src/pkg/exp/template/parse.go (right):

http://codereview.appspot.com/4641096/diff/1/src/pkg/exp/template/parse.go#ne...
src/pkg/exp/template/parse.go:564: b, err := ioutil.ReadFile(filename)
maybe the template name should be the base name of the file name.

[r, 2011-07-08 05:28:50]

http://codereview.appspot.com/4641096/diff/1/src/pkg/exp/template/parse.go
File src/pkg/exp/template/parse.go (right):

http://codereview.appspot.com/4641096/diff/1/src/pkg/exp/template/parse.go#ne...
src/pkg/exp/template/parse.go:564: b, err := ioutil.ReadFile(filename)
On 2011/07/08 05:25:14, r wrote:
> maybe the template name should be the base name of the file name.

never mind, but provide functions that do this.

[adg, 2011-07-08 05:40:39]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-07-08 05:46:00]

http://codereview.appspot.com/4641096/diff/4002/src/pkg/exp/template/helper.go
File src/pkg/exp/template/helper.go (right):

http://codereview.appspot.com/4641096/diff/4002/src/pkg/exp/template/helper.g...
src/pkg/exp/template/helper.go:1: package template
add a comment saying what these are.

http://codereview.appspot.com/4641096/diff/4002/src/pkg/exp/template/helper.g...
src/pkg/exp/template/helper.go:45: // cannot be read or the template cannot be
parsed.
just write out the definition rather than saying it's like ParseFile. it's nice
to have them self-contained.
same for the others.

[adg, 2011-07-08 05:54:00]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-07-08 06:00:10]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-07-08 06:00:26]

LGTM

[adg, 2011-07-08 06:01:38]

*** Submitted as http://code.google.com/p/go/source/detail?r=f34c5200230d ***

exp/template: the must-have MustParse functions

R=r
CC=golang-dev
http://codereview.appspot.com/4641096