Issue 4641075: code review 4641075: ebnflint: better handling of stdin

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4641075: code review 4641075: ebnflint: better handling of stdin (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by gri

Modified:
13 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

ebnflint: better handling of stdin - don't rely on /dev/stdin as the name for standard input - employ EBNF extraction if the source contains tags "cat source.html | ebnflint" works now

Patch Set 2 : diff -r 90f9c658e53d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 90f9c658e53d https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 34ec6987d751 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -11 lines)			Patch
	M	src/cmd/ebnflint/ebnflint.go	View	1 2 3	2 chunks	+18 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-06-25 00:09:01 UTC) #1

LGTM http://codereview.appspot.com/4641075/diff/4001/src/cmd/ebnflint/ebnflint.go File src/cmd/ebnflint/ebnflint.go (right): http://codereview.appspot.com/4641075/diff/4001/src/cmd/ebnflint/ebnflint.go#newcode91 src/cmd/ebnflint/ebnflint.go:91: filename = "<standard input>" the traditional name for ...

13 years, 11 months ago (2011-06-25 00:21:02 UTC) #2

gri

13 years, 11 months ago (2011-06-25 00:29:21 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d847323c0fbf ***

ebnflint: better handling of stdin

- don't rely on /dev/stdin as the name for standard input
- employ EBNF extraction if the source contains tags

"cat source.html | ebnflint" works now

R=r
CC=golang-dev
http://codereview.appspot.com/4641075

Expand All Messages | Collapse All Messages