Issue 4639041: code review 4639041: sort: change the name of Float64Array to Float64Slice.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4639041: code review 4639041: sort: change the name of Float64Array to Float64Slice. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by r

Modified:
12 years, 11 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

sort: change the name of Float64Array to Float64Slice. I missed this before because I used the wrong regexp. What a moron.

Patch Set 2 : diff -r df607ef238c9 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 001f5f776015 https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -28 lines)			Patch
M	src/pkg/sort/search.go	View	1 2	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/sort/search_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/sort/sort.go	View	1 2	4 chunks	+16 lines, -16 lines	0 comments	Download
M	src/pkg/sort/sort_test.go	View	1 2	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2011-06-16 07:39:01 UTC) #1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 11 months ago (2011-06-16 07:40:41 UTC) #2

dsymonds

LGTM http://codereview.appspot.com/4639041/diff/3001/src/pkg/sort/sort.go File src/pkg/sort/sort.go (right): http://codereview.appspot.com/4639041/diff/3001/src/pkg/sort/sort.go#newcode195 src/pkg/sort/sort.go:195: // SortFloat64s sorts an array of float64s in ...

12 years, 11 months ago (2011-06-16 07:42:23 UTC) #3

12 years, 11 months ago (2011-06-16 07:48:12 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=dd3913e4b4b9 ***

sort: change the name of Float64Array to Float64Slice.
I missed this before because I used the wrong regexp. What a moron.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4639041

Expand All Messages | Collapse All Messages