Issue 4635071: code review 4635071: 5l, 6l, 8l: drop use of ed during build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4635071: code review 4635071: 5l, 6l, 8l: drop use of ed during build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by rsc

Modified:
13 years, 10 months ago

Reviewers:
peterGo, r2

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

5l, 6l, 8l: drop use of ed during build build runs with chmod 0 /bin/ed now

Patch Set 2 : diff -r 0fa9924e12c1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0fa9924e12c1 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0fa9924e12c1 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -48 lines)			Patch
M	doc/install.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/5l/mkenam	View	1	1 chunk	+15 lines, -15 lines	0 comments	Download
M	src/cmd/6l/mkenam	View	1	1 chunk	+15 lines, -15 lines	0 comments	Download
M	src/cmd/8l/mkenam	View	1	1 chunk	+15 lines, -15 lines	0 comments	Download
M	src/env.bash	View	1	1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-06-27 15:17:04 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=d647efcd873b *** 5l, 6l, 8l: drop use of ed during build build ...

13 years, 10 months ago (2011-06-27 16:03:29 UTC) #3

peterGo

http://codereview.appspot.com/4635071/diff/6006/src/env.bash File src/env.bash (right): http://codereview.appspot.com/4635071/diff/6006/src/env.bash#newcode76 src/env.bash:76: for i in bison ed awk gcc $MAKE; do ...

13 years, 10 months ago (2011-06-27 16:34:24 UTC) #4

rsc

13 years, 10 months ago (2011-06-27 21:43:02 UTC) #6

On Mon, Jun 27, 2011 at 17:25, Rob 'Commander' Pike <r@google.com> wrote:
> I guess ed is no longer the standard editor.

It's definitely not the standard scripting language.

Russ

Expand All Messages | Collapse All Messages