Issue 4634122: proposed fix for pr10233

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4634122: proposed fix for pr10233

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by nlewycky1

Modified:
12 years, 10 months ago

Reviewers:
chandlerc

Base URL:
http://llvm.org/svn/llvm-project/cfe/trunk/

Visibility:
Public.

Patch Set 2 : Refactor! #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -3 lines)			Patch
M	include/clang/AST/Decl.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/AST/ASTContext.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/AST/Decl.cpp	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
M	lib/CodeGen/CodeGenModule.cpp	View	1	2 chunks	+15 lines, -2 lines	0 comments	Download
M	test/CodeGen/inline.c	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

chandlerc

http://codereview.appspot.com/4634122/diff/1/lib/CodeGen/CodeGenModule.cpp File lib/CodeGen/CodeGenModule.cpp (right): http://codereview.appspot.com/4634122/diff/1/lib/CodeGen/CodeGenModule.cpp#newcode759 lib/CodeGen/CodeGenModule.cpp:759: llvm::StringMap<GlobalDecl>::iterator DDI = DeferredDecls.find(MangledName); 80 column spidey sense tingles...

12 years, 10 months ago (2011-07-02 02:21:40 UTC) #1

nlewycky1

12 years, 10 months ago (2011-07-04 19:05:31 UTC) #2

Since the only change is an 80-col fix, I'm not going to bother reuploading.
Thanks for the review!

http://codereview.appspot.com/4634122/diff/1/lib/CodeGen/CodeGenModule.cpp
File lib/CodeGen/CodeGenModule.cpp (right):

http://codereview.appspot.com/4634122/diff/1/lib/CodeGen/CodeGenModule.cpp#ne...
lib/CodeGen/CodeGenModule.cpp:759: llvm::StringMap<GlobalDecl>::iterator DDI =
DeferredDecls.find(MangledName);
On 2011/07/02 02:21:40, chandlerc wrote:
> 80 column spidey sense tingles...

Done.

Expand All Messages | Collapse All Messages