Issue 4634063: code review 4634063: mime: fix RFC references

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4634063: code review 4634063: mime: fix RFC references (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by pascal

Modified:
13 years, 10 months ago

Reviewers:

CC:
golang-dev, bradfitz, brad fitzpatrick

Visibility:
Public.

Description

mime: fix RFC references

Patch Set 1 #

Patch Set 2 : diff -r 61ed63d57306 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4d789ab9a41d https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/pkg/mime/grammar.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/pkg/mime/mediatype.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

pascal

Hello golang-dev@googlegroups.com (cc: brad fitzpatrick <bradfitz@golang.org>, golang-dev@googlegroups.com), I'd like you to review this change to ...

13 years, 10 months ago (2011-06-18 16:43:45 UTC) #1

pascal

Hello golang-dev@googlegroups.com (cc: brad fitzpatrick <bradfitz@golang.org>, golang-dev@googlegroups.com), Please take another look.

13 years, 10 months ago (2011-06-20 09:03:59 UTC) #2

bradfitz

LGTM On Mon, Jun 20, 2011 at 2:04 AM, <pascal@quies.net> wrote: > Hello golang-dev@googlegroups.com (cc: ...

13 years, 10 months ago (2011-06-20 14:41:06 UTC) #3

bradfitz

13 years, 10 months ago (2011-06-20 14:41:27 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=6f1145ee588d ***

mime: fix RFC references

R=golang-dev, bradfitz
CC=brad fitzpatrick <bradfitz, golang-dev
http://codereview.appspot.com/4634063

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages