code review 4634043: cgo: make file path work for windows

cgo: make file path work for windows

[brainman, 2011-06-16 06:55:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[mattn, 2011-06-16 07:07:11]

http://codereview.appspot.com/4634043/diff/3001/src/cmd/cgo/util.go
File src/cmd/cgo/util.go (right):

http://codereview.appspot.com/4634043/diff/3001/src/cmd/cgo/util.go#newcode106
src/cmd/cgo/util.go:106: if c == '/' || c == '\\' {
You have better to use os.IsPathSeparator(uint8(c)).

[brainman, 2011-06-16 07:09:44]

http://codereview.appspot.com/4634043/diff/3001/src/cmd/cgo/util.go
File src/cmd/cgo/util.go (right):

http://codereview.appspot.com/4634043/diff/3001/src/cmd/cgo/util.go#newcode106
src/cmd/cgo/util.go:106: if c == '/' || c == '\\' {
On 2011/06/16 07:07:11, mattn wrote:
> You have better to use os.IsPathSeparator(uint8(c)).

No, I just want to replace both '/' and '\\' with '_'.

[mattn, 2011-06-16 07:14:31]

On 2011/06/16 07:09:44, brainman wrote:
> http://codereview.appspot.com/4634043/diff/3001/src/cmd/cgo/util.go
> File src/cmd/cgo/util.go (right):
> 
> http://codereview.appspot.com/4634043/diff/3001/src/cmd/cgo/util.go#newcode106
> src/cmd/cgo/util.go:106: if c == '/' || c == '\\' {
> On 2011/06/16 07:07:11, mattn wrote:
> > You have better to use os.IsPathSeparator(uint8(c)).
> 
> No, I just want to replace both '/' and '\\' with '_'.

Is this a full path?
Then, you should add checking ':'.

[brainman, 2011-06-16 07:23:37]

On 2011/06/16 07:14:31, mattn wrote:
> Then, you should add checking ':'.

You're, probably, right. Please, take another look.

Alex

[adg, 2011-06-17 00:12:21]

LGTM

[adg, 2011-06-17 00:17:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=4795e1786223 ***

cgo: make file path work for windows

R=golang-dev, mattn.jp, adg
CC=golang-dev
http://codereview.appspot.com/4634043

Committer: Andrew Gerrand <adg@golang.org>

[brainman, 2011-06-17 01:53:52]

*** Abandoned ***