Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1449)

Issue 4633064: Changes himidtom to highmidtom. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by MikeSol
Modified:
12 years, 11 months ago
Reviewers:
Keith, mike, Graham Percival (old account), t.daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Changes himidtom to highmidtom.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Documentation/included/percussion-chart.ly View 1 chunk +1 line, -1 line 0 comments Download
M ly/drumpitch-init.ly View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
MikeSol
Pretty self explanatory - it seems to be in keeping w/ the other tom names. ...
12 years, 11 months ago (2011-06-23 06:46:49 UTC) #1
Keith
On 2011/06/23 06:46:49, MikeSol wrote: > Pretty self explanatory - it seems to be in ...
12 years, 11 months ago (2011-06-23 08:53:26 UTC) #2
mike_apollinemike.com
On Jun 23, 2011, at 10:53 AM, k-ohara5a5a@oco.net wrote: > On 2011/06/23 06:46:49, MikeSol wrote: ...
12 years, 11 months ago (2011-06-23 08:57:00 UTC) #3
t.daniels_treda.co.uk
mike@apollinemike.com wrote Thursday, June 23, 2011 9:56 AM > On Jun 23, 2011, at 10:53 ...
12 years, 11 months ago (2011-06-23 09:49:05 UTC) #4
Graham Percival (old account)
12 years, 11 months ago (2011-06-23 11:22:26 UTC) #5
On 2011/06/23 09:49:05, t.daniels_treda.co.uk wrote:
> mailto:mike@apollinemike.com wrote Thursday, June 23, 2011 9:56 AM
> The names in LilyPond should conform to those defined
> in General MIDI Level 1 - see 
> http://www.midi.org/techspecs/gm1sound.php
> 
> These are unfortunately inconsistent as you observe,
> but we should stay with them.

I agree.  Random other page which uses the same inconsistent naming:

http://www.finalemusic.com/usermanuals/finale2011win/content/finale/General_M...
48 Hi-Mid Tom
50 High Tom

I think we therefore cannot accept this patch, sorry Mike.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b