Issue 4632052: code review 4632052: exp/regexp/syntax: case-folding in character classes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4632052: code review 4632052: exp/regexp/syntax: case-folding in character classes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by rsc

Modified:
13 years, 10 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

exp/regexp/syntax: case-folding in character classes Also fix \x{123} parsing.

Patch Set 2 : diff -r 18e35543f1af https://go.googlecode.com/hg/ #

Total comments: 5

Patch Set 3 : diff -r cb5ad47b6e02 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+207 lines, -39 lines)			Patch
	M	src/pkg/exp/regexp/syntax/parse.go	View	1 2	10 chunks	+128 lines, -33 lines	0 comments	Download
	M	src/pkg/exp/regexp/syntax/parse_test.go	View	1 2	3 chunks	+79 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-06-28 03:12:44 UTC) #1

LGTM http://codereview.appspot.com/4632052/diff/2001/src/pkg/exp/regexp/syntax/parse.go File src/pkg/exp/regexp/syntax/parse.go (right): http://codereview.appspot.com/4632052/diff/2001/src/pkg/exp/regexp/syntax/parse.go#newcode84 src/pkg/exp/regexp/syntax/parse.go:84: tmpClass []int // comment please http://codereview.appspot.com/4632052/diff/2001/src/pkg/exp/regexp/syntax/parse.go#newcode1067 src/pkg/exp/regexp/syntax/parse.go:1067: // ...

13 years, 10 months ago (2011-06-28 03:19:32 UTC) #2

rsc

> http://codereview.appspot.com/4632052/diff/2001/src/pkg/exp/regexp/syntax/parse_test.go#newcode67 > src/pkg/exp/regexp/syntax/parse_test.go:67: {"[a]", "cc{0x61}"}, > why don't you use raw strings in most ...

13 years, 10 months ago (2011-06-28 03:23:25 UTC) #3

rsc

13 years, 10 months ago (2011-06-28 03:23:54 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=698796ea5c3e ***

exp/regexp/syntax: case-folding in character classes

Also fix \x{123} parsing.

R=r
CC=golang-dev
http://codereview.appspot.com/4632052

Expand All Messages | Collapse All Messages