Issue 4631086: Fixes multiple line glissandos the right way.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4631086: Fixes multiple line glissandos the right way. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by MikeSol

Modified:
12 years, 10 months ago

Reviewers:
mike, carl.d.sorensen, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fixes multiple line glissandos the right way.

Patch Set 1 #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -72 lines)			Patch
M	lily/line-spanner.cc	View	1 chunk	+48 lines, -37 lines	0 comments	Download
M	scm/define-grobs.scm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scm/output-lib.scm	View	1 chunk	+0 lines, -34 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

MikeSol

Passes regtests - should be good to go! Thanks to Neil & Han-Wen for the ...

12 years, 10 months ago (2011-07-04 08:02:03 UTC) #1

Neil Puttock

LGTM apart from some indentation infelicities (space before tab in indent).

12 years, 10 months ago (2011-07-04 21:49:02 UTC) #2

mike_apollinemike.com

12 years, 10 months ago (2011-07-05 07:20:25 UTC) #4

On Jul 4, 2011, at 11:49 PM, n.puttock@gmail.com wrote:

> LGTM apart from some indentation infelicities (space before tab in
> indent).
> 
> http://codereview.appspot.com/4631086/

Infelicities incapacitated, pushed as 0c258f3f339573d25080dadd0a1a5078ec35b09a.

Cheers,
MS

Expand All Messages | Collapse All Messages