code review 4629051: Make.ccmd: link with mach lib,

Make.ccmd: link with mach lib,
remove explicit linking in make files

[Joe Poirier, 2011-06-18 13:41:24]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r2, 2011-06-18 22:38:25]

why?

-rob

[Joe Poirier, 2011-06-19 03:44:21]

On Jun 18, 2011, at Jun 18 - 5:38 PM, Rob 'Commander' Pike wrote:

> why?
> 
> -rob
> 

Because it's correct.

Concerning -lm, it (libm.a) doesn't exist so it needs to be removed. lib9 and
libbio are being linked to but libmach is conspicuously missing, yet it lives in
the same lib folder. A grep for libmach reveals some lower level make files
attempting to bypass the build chain hierarchy by explicitly linking to the file
by name with a relative path. 

In this CL, changes to the file's name and/or location, however unlikely, only
need to be set in a single file and, more importantly, we let the build tool
handle the library file's prefix and suffix, which is better for cross-platform
builds. A bad example would be on a Windows system, outside of MSYS, mach.lib
would be more common and make would know it. 

-joe    

    

[r, 2011-06-19 03:56:53]

LGTM

Thanks for the explanation.

[r, 2011-06-19 03:57:30]

*** Submitted as http://code.google.com/p/go/source/detail?r=2f38a0262214 ***

Make.ccmd: link with mach lib,
remove explicit linking in make files

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4629051

Committer: Rob Pike <r@golang.org>

[dave_cheney.net, 2011-06-19 04:11:07]

I think you need to include -lm after all.

%%%% making 6g %%%%

make -C 6g install
make[1]: Entering directory `/home/dfc/go/src/cmd/6g'
quietgcc -o 6g -L"/home/dfc/go"/lib ../6l/enam.o cgen.o cplx.o galign.o ggen.o
gobj.o gsubr.o list.o peep.o pgen.o reg.o  ../gc/gc.a  -lbio -l9 -lmach 
/home/dfc/go/src/cmd/gc/mparith3.c:276: undefined reference to `floor'
collect2: ld returned 1 exit status
make[1]: *** [6g] Error 1
make[1]: Leaving directory `/home/dfc/go/src/cmd/6g'
make: *** [6g.install] Error 2
make: Leaving directory `/home/dfc/go/src/cmd'

[dave_cheney.net, 2011-06-19 04:17:49]

In addition, this CL passes just fine on darwin/amd64, but fails on linux/amd64
(debian 6)

[Joe Poirier, 2011-06-19 04:39:40]

On Jun 18, 2011, at Jun 18 - 11:17 PM, dave@cheney.net wrote:

> In addition, this CL passes just fine on darwin/amd64, but fails on
> linux/amd64 (debian 6)
> 
> http://codereview.appspot.com/4629051/

I did the CL and testing on OSX. Just tested it on Windows and it fails there as
well.

make -C godefs install
make[1]: Entering directory `/c/go/src/cmd/cc'
LANG=C LANGUAGE="en_US.UTF8" bison -v -y -d cc.y
conflicts: 3 shift/reduce
make[1]: Entering directory `/c/go/src/cmd/8l'
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/8l/asm.c"
test -f y.tab.c && touch y.tab.c
make[1]: Entering directory `/c/go/src/cmd/godefs'
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/godefs/main.c"
make[1]: Entering directory `/c/go/src/cmd/cov'
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cov/main.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/lex.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cov/tree.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/godefs/stabs.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c -I. ../ld/data.c
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/mac.c"
quietgcc -o 6cov.exe -L"/c/go"/lib main.o tree.o   -lbio -l9 -lmach
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/godefs/util.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c -I. ../ld/dwarf.c
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/dcl.c"
c:/go/src/libmach/machdata.c:114: undefined reference to `snprint'
c:/go/src/libmach/machdata.c:118: undefined reference to `snprint'
c:/go/src/libmach/machdata.c:116: undefined reference to `snprint'
c:/go/src/libmach/machdata.c:237: undefined reference to `snprint'
c:/go/src/libmach/machdata.c:227: undefined reference to `snprint'
c:/go/lib/libmach.a(machdata.o):c:/go/src/libmach/machdata.c:222: more undefined
references to `snprint' follow
c:/go/src/libmach/sym.c:131: undefined reference to `Bseek'
c:/go/src/libmach/sym.c:259: undefined reference to `Bseek'
c:/go/src/libmach/sym.c:265: undefined reference to `Bseek'
c:/go/src/libmach/sym.c:266: undefined reference to `Bgetc'
c:/go/src/libmach/sym.c:271: undefined reference to `Bgetc'
c:/go/src/libmach/sym.c:272: undefined reference to `Bgetc'
c:/go/src/libmach/sym.c:280: undefined reference to `Bseek'
c:/go/src/libmach/sym.c:286: undefined reference to `Bseek'
c:/go/src/libmach/sym.c:213: undefined reference to `Bseek'
c:/go/src/libmach/sym.c:226: undefined reference to `Bseek'
c:/go/src/libmach/sym.c:1187: undefined reference to `cleanname'
c:/go/src/libmach/sym.c:1149: undefined reference to `sprint'
c:/go/src/libmach/executable.c:1067: undefined reference to `p9seek'
c:/go/src/libmach/executable.c:890: undefined reference to `p9seek'
c:/go/src/libmach/executable.c:900: undefined reference to `p9seek'
c:/go/src/libmach/executable.c:712: undefined reference to `p9seek'
c:/go/src/libmach/executable.c:722: undefined reference to `p9seek'
c:/go/lib/libmach.a(executable.o):c:/go/src/libmach/executable.c:966: more
undefined references to `p9seek' follow
c:/go/src/libmach/executable.c:326: undefined reference to `dirstat'
c:/go/src/libmach/8db.c:1606: undefined reference to `snprint'
c:/go/src/libmach/8db.c:128: undefined reference to `snprint'
c:/go/src/libmach/5db.c:609: undefined reference to `sprint'
c:/go/src/libmach/5db.c:534: undefined reference to `sprint'
c:/go/src/libmach/5db.c:576: undefined reference to `sprint'
c:/go/src/libmach/5db.c:541: undefined reference to `sprint'
c:/go/src/libmach/5db.c:560: undefined reference to `sprint'
c:/go/lib/libmach.a(5db.o):c:/go/src/libmach/5db.c:548: more undefined
references to `sprint' follow
c:/go/src/libmach/5db.c:304: undefined reference to `snprint'
c:/go/src/libmach/5db.c:312: undefined reference to `snprint'
c:/go/src/libmach/5db.c:310: undefined reference to `snprint'
c:/go/src/libmach/5db.c:308: undefined reference to `snprint'
c:/go/src/libmach/5db.c:481: undefined reference to `snprint'
c:/go/lib/libmach.a(5db.o):c:/go/src/libmach/5db.c:478: more undefined
references to `snprint' follow
collect2: ld returned 1 exit status
make[1]: *** [6cov.exe] Error 1
make[1]: Leaving directory `/c/go/src/cmd/cov'
make: *** [cov.install] Error 2
make: *** Waiting for unfinished jobs....
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/acid.c"
quietgcc -o godefs.exe -L"/c/go"/lib main.o stabs.o util.o   -lbio -l9 -lmach
cp godefs.exe "/c/go/bin"/godefs.exe
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/godefs.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c -I. ../ld/elf.c
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/bits.c"
make[1]: Leaving directory `/c/go/src/cmd/godefs'
sh mkenam
quietgcc -I"/c/go/include" -ggdb -O2 -c -I. ../ld/go.c
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/com.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/scon.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c -I. ../ld/ldelf.c
quietgcc -I"/c/go/include" -ggdb -O2 -c -I. ../ld/ldmacho.c
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/funct.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c -I. ../ld/ldpe.c
quietgcc -I"/c/go/include" -ggdb -O2 -c -I. ../ld/lib.c
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/8l/list.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/sub.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c -I. ../ld/macho.c
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/8l/obj.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/8l/optab.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/8l/pass.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c -I. ../ld/pe.c
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/com64.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/8l/prof.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/8l/span.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c -I. ../ld/symtab.c
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/dpchk.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/8l/enam.c"
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/omachcap.c"
quietgcc -o 8l.exe -L"/c/go"/lib asm.o data.o dwarf.o elf.o enam.o go.o ldelf.o
ldmacho.o ldpe.o lib.o list.o macho.o obj.o optab.o pas                         
           s.o pe.o prof.o span.o symtab.o   -lbio -l9 -lmach
quietgcc -I"/c/go/include" -ggdb -O2 -c "/c/go/src/cmd/cc/y.tab.c"
cp 8l.exe "/c/go/bin"/8l.exe
make[1]: Leaving directory `/c/go/src/cmd/8l'
ar rsc cc.a y.tab.o lex.o mac.o dcl.o acid.o godefs.o bits.o com.o scon.o
funct.o sub.o com64.o dpchk.o omachcap.o
make[1]: Leaving directory `/c/go/src/cmd/cc'
make: Leaving directory `/c/go/src/cmd'

[ality, 2011-06-19 04:54:33]

jdpoirier@gmail.com once said:
>  $(TARG): $(OFILES) $(LIB)
> -	$(HOST_LD) -o $(TARG) -L"$(GOROOT)"/lib $(OFILES) $(LIB) -lbio -l9 -lm
$(HOST_LDFLAGS)
> +	$(HOST_LD) -o $(TARG) -L"$(GOROOT)"/lib $(OFILES) $(LIB) -lbio -l9 -lmach
$(HOST_LDFLAGS)

You need to put -lmach before -lbio.
I'd be surprised if this linked.

  Anthony

[r2, 2011-06-19 04:55:12]

On 19/06/2011, at 2:54 PM, Anthony Martin wrote:

> jdpoirier@gmail.com once said:
>> $(TARG): $(OFILES) $(LIB)
>> -	$(HOST_LD) -o $(TARG) -L"$(GOROOT)"/lib $(OFILES) $(LIB) -lbio -l9 -lm
$(HOST_LDFLAGS)
>> +	$(HOST_LD) -o $(TARG) -L"$(GOROOT)"/lib $(OFILES) $(LIB) -lbio -l9 -lmach
$(HOST_LDFLAGS)
> 
> You need to put -lmach before -lbio.
> I'd be surprised if this linked.
> 
>  Anthony

you're right, and it didn't.

-rob

[Joe Poirier, 2011-06-19 05:19:23]

On Jun 18, 2011, at Jun 18 - 11:55 PM, Rob 'Commander' Pike wrote:

> 
> On 19/06/2011, at 2:54 PM, Anthony Martin wrote:
> 
>> jdpoirier@gmail.com once said:
>>> $(TARG): $(OFILES) $(LIB)
>>> -	$(HOST_LD) -o $(TARG) -L"$(GOROOT)"/lib $(OFILES) $(LIB) -lbio -l9 -lm
$(HOST_LDFLAGS)
>>> +	$(HOST_LD) -o $(TARG) -L"$(GOROOT)"/lib $(OFILES) $(LIB) -lbio -l9 -lmach
$(HOST_LDFLAGS)
>> 
>> You need to put -lmach before -lbio.
>> I'd be surprised if this linked.
>> 
>> Anthony
> 
> you're right, and it didn't.
> 
> -rob
> 

The reorder fixed my Windows build. Even though it compiled on OSX I should've
seen the order in the make files! 

Thanks,
Joe